src/utils/SkDeferredCanvas.cpp - Issue 2234843002: Revert of Change mapRectScaleTranslate to pass args/ret by value

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/utils/SkDeferredCanvas.cpp

Issue 2234843002: Revert of Change mapRectScaleTranslate to pass args/ret by value (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/utils/SkDeferredCanvas.cpp

diff --git a/src/utils/SkDeferredCanvas.cpp b/src/utils/SkDeferredCanvas.cpp

index c8a37c36b7805947c5f4527ffa8f159a072f0990..14220209cc952717a493662b1a4e7f14a64f2870 100644

--- a/src/utils/SkDeferredCanvas.cpp

+++ b/src/utils/SkDeferredCanvas.cpp

@@ -200,7 +200,7 @@

if (canScale) {

SkMatrix m;

rec.getConcat(&m);

- *bounds = m.mapRectScaleTranslate(*bounds);

+ m.mapRectScaleTranslate(bounds, *bounds);

} else {

goto STOP;

}

« no previous file with comments | « src/core/SkMatrix.cpp ('k') | tests/MatrixTest.cpp » ('j') | no next file with comments »