Added UseCounter for navigator.share (WebShareShare).

Added UseCounter for navigator.share (WebShareShare).

BUG=636288
Committed: https://crrev.com/fdbed09a1c4a58bd823a99c9fa0b4597be824300
Cr-Commit-Position: refs/heads/master@{#411273}

[Matt Giuca, 2016-08-10 09:17:19]

mgiuca@chromium.org changed reviewers:
+ esprehn@chromium.org, jwd@chromium.org

[Matt Giuca, 2016-08-10 09:17:20]

Adding just a UseCounter at this stage. I also intend to add more detailed
metrics, e.g., whether the user cancelled, but those will be done separately
(through the Java implementation).

[Matt Giuca, 2016-08-10 09:17:41]

jwd: For histograms.xml
esprehn: For code in WebKit.

[Matt Giuca, 2016-08-10 09:24:15]

Description was changed from

==========
Added UseCounter for navigator.share (WebShareShare).

BUG=635805
==========

to

==========
Added UseCounter for navigator.share (WebShareShare).

BUG=636288
==========

[jwd, 2016-08-10 17:43:12]

lgtm

[esprehn, 2016-08-10 17:58:58]

lgtm

https://codereview.chromium.org/2234723002/diff/1/third_party/WebKit/Source/m...
File third_party/WebKit/Source/modules/webshare/NavigatorShare.cpp (right):

https://codereview.chromium.org/2234723002/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/webshare/NavigatorShare.cpp:87:
UseCounter::count(doc, UseCounter::WebShareShare);
You're actually calling the ExecutionContext version of count() here which does
a bunch of checks:
https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/frame/Use...

if you do:

*doc instead you'll be calling the Document& one which is better.

[Matt Giuca, 2016-08-11 03:33:18]

https://codereview.chromium.org/2234723002/diff/1/third_party/WebKit/Source/m...
File third_party/WebKit/Source/modules/webshare/NavigatorShare.cpp (right):

https://codereview.chromium.org/2234723002/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/webshare/NavigatorShare.cpp:87:
UseCounter::count(doc, UseCounter::WebShareShare);
On 2016/08/10 17:58:58, esprehn wrote:
> You're actually calling the ExecutionContext version of count() here which
does
> a bunch of checks:
>
https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/frame/Use...
> 
> if you do:
> 
> *doc instead you'll be calling the Document& one which is better.

D'oh. That's pretty confusing (I was deliberately trying to avoid the
ExecutionContext overload but I failed).

[Matt Giuca, 2016-08-11 03:33:49]

The CQ bit was checked by mgiuca@chromium.org

[Matt Giuca, 2016-08-11 03:33:49]

The patchset sent to the CQ was uploaded after l-g-t-m from
esprehn@chromium.org, jwd@chromium.org
Link to the patchset: https://codereview.chromium.org/2234723002/#ps20001
(title: "Use the right overload of UseCounter::count.")

[commit-bot: I haz the power, 2016-08-11 03:34:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-11 03:36:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-11 03:37:02]

Try jobs failed on following builders:
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  chromeos_x86-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Matt Giuca, 2016-08-11 04:02:22]

The CQ bit was checked by mgiuca@chromium.org

[Matt Giuca, 2016-08-11 04:02:22]

The patchset sent to the CQ was uploaded after l-g-t-m from
esprehn@chromium.org, jwd@chromium.org
Link to the patchset: https://codereview.chromium.org/2234723002/#ps40001
(title: "Rebase.")

[commit-bot: I haz the power, 2016-08-11 04:02:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-11 05:24:54]

Description was changed from

==========
Added UseCounter for navigator.share (WebShareShare).

BUG=636288
==========

to

==========
Added UseCounter for navigator.share (WebShareShare).

BUG=636288
==========

[commit-bot: I haz the power, 2016-08-11 05:24:55]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-08-11 05:26:16]

Description was changed from

==========
Added UseCounter for navigator.share (WebShareShare).

BUG=636288
==========

to

==========
Added UseCounter for navigator.share (WebShareShare).

BUG=636288

Committed: https://crrev.com/fdbed09a1c4a58bd823a99c9fa0b4597be824300
Cr-Commit-Position: refs/heads/master@{#411273}
==========

[commit-bot: I haz the power, 2016-08-11 05:26:17]

Patchset 3 (id:??) landed as
https://crrev.com/fdbed09a1c4a58bd823a99c9fa0b4597be824300
Cr-Commit-Position: refs/heads/master@{#411273}