Added UseCounter for navigator.share (WebShareShare).

third_party/WebKit/Source/modules/webshare/NavigatorShare.cpp

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "modules/webshare/NavigatorShare.h"
 
 #include "core/dom/DOMException.h"
 #include "core/dom/Document.h"
 #include "core/dom/ExceptionCode.h"
 #include "core/frame/LocalFrame.h"
 #include "core/frame/Navigator.h"
+#include "core/frame/UseCounter.h"
 #include "modules/webshare/ShareData.h"
 #include "platform/mojo/MojoHelper.h"
 #include "public/platform/InterfaceProvider.h"
 #include "public/platform/Platform.h"
 
 namespace blink {
 
 class NavigatorShare::ShareClientImpl final : public GarbageCollected<ShareClientImpl> {
 public:
     ShareClientImpl(NavigatorShare*, ScriptPromiseResolver*);
@@ skipping 52 matching lines @@
 {
 }
 
 const char* NavigatorShare::supplementName()
 {
     return "NavigatorShare";
 }
 
 ScriptPromise NavigatorShare::share(ScriptState* scriptState, const ShareData& shareData)
 {
+    Document* doc = toDocument(scriptState->getExecutionContext());
+    DCHECK(doc);
+    UseCounter::count(doc, UseCounter::WebShareShare);

[esprehn, 2016/08/10 17:58:58]

You're actually calling the ExecutionContext version of count() here which does
a bunch of checks:
https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/frame/Use...

if you do:

*doc instead you'll be calling the Document& one which is better.

[Matt Giuca, 2016/08/11 03:33:17]

D'oh. That's pretty confusing (I was deliberately trying to avoid the
ExecutionContext overload but I failed).

+
     if (!m_service) {
-        Document* doc = toDocument(scriptState->getExecutionContext());
-        DCHECK(doc);
         LocalFrame* frame = doc->frame();
         DCHECK(frame);
         frame->interfaceProvider()->getInterface(mojo::GetProxy(&m_service));
         DCHECK(m_service);
     }
 
     ScriptPromiseResolver* resolver = ScriptPromiseResolver::create(scriptState);
     ShareClientImpl* client = new ShareClientImpl(this, resolver);
     m_clients.add(client);
     ScriptPromise promise = resolver->promise();
 
     // TODO(sammc): Use shareData.url().
     m_service->Share(shareData.hasTitle() ? shareData.title() : emptyString(), shareData.hasText() ? shareData.text() : emptyString(), convertToBaseCallback(WTF::bind(&ShareClientImpl::callback, wrapPersistent(client))));
 
     return promise;
 }
 
 ScriptPromise NavigatorShare::share(ScriptState* scriptState, Navigator& navigator, const ShareData& shareData)
 {
     return from(navigator).share(scriptState, shareData);
 }
 
 } // namespace blink