Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 2234683002: Remove EffectModel IDL interface (Closed)

Created:
4 years, 4 months ago by suzyh_UTC10 (ex-contributor)
Modified:
4 years, 4 months ago
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, blink-reviews-bindings_chromium.org, chromium-reviews, Eric Willigers, rjwright, shans
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove EffectModel IDL interface EffectModel is not a specced part of the Web Animations interface http://w3c.github.io/web-animations/ and has not been shipped. This patch therefore removes EffectModel and all references to it from the IDL, in particular as a valid type for the effect argument of Element.animate(). The EffectModel class is maintained as a part of the Web Animations implementation. BUG=624639 Committed: https://crrev.com/8e90d746cd42c66d5565b8a08220b83378a35e24 Cr-Commit-Position: refs/heads/master@{#411239}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -53 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/generated.gni View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/generated.gypi View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/animation/EffectInput.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/animation/EffectInput.cpp View 2 chunks +2 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/animation/EffectInputTest.cpp View 6 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/animation/EffectModel.h View 2 chunks +1 line, -3 lines 0 comments Download
D third_party/WebKit/Source/core/animation/EffectModel.idl View 1 chunk +0 lines, -14 lines 0 comments Download
M third_party/WebKit/Source/core/animation/ElementAnimation.h View 1 4 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/animation/ElementAnimation.idl View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/animation/KeyframeEffect.h View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/animation/KeyframeEffect.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/animation/KeyframeEffect.idl View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/animation/KeyframeEffectTest.cpp View 1 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/core.gypi View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 26 (14 generated)
suzyh_UTC10 (ex-contributor)
4 years, 4 months ago (2016-08-10 03:25:32 UTC) #4
alancutter (OOO until 2018)
lgtm
4 years, 4 months ago (2016-08-10 03:28:18 UTC) #5
suzyh_UTC10 (ex-contributor)
+haraken for bindings and core/core.gypi OWNERS
4 years, 4 months ago (2016-08-10 04:09:36 UTC) #7
haraken
On 2016/08/10 04:09:36, suzyh wrote: > +haraken for bindings and core/core.gypi OWNERS LGTM
4 years, 4 months ago (2016-08-10 04:20:32 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2234683002/1
4 years, 4 months ago (2016-08-10 04:49:04 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/234653)
4 years, 4 months ago (2016-08-10 04:54:20 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2234683002/20001
4 years, 4 months ago (2016-08-10 05:48:51 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/270670)
4 years, 4 months ago (2016-08-10 08:20:50 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2234683002/20001
4 years, 4 months ago (2016-08-10 23:33:37 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2234683002/20001
4 years, 4 months ago (2016-08-11 00:00:07 UTC) #23
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-11 02:59:36 UTC) #24
commit-bot: I haz the power
4 years, 4 months ago (2016-08-11 03:00:56 UTC) #26
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8e90d746cd42c66d5565b8a08220b83378a35e24
Cr-Commit-Position: refs/heads/master@{#411239}

Powered by Google App Engine
This is Rietveld 408576698