third_party/WebKit/Source/core/animation/KeyframeEffect.cpp - Issue 2234683002: Remove EffectModel IDL interface

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/animation/KeyframeEffect.cpp

Issue 2234683002: Remove EffectModel IDL interface (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/animation/KeyframeEffect.h ('k') | third_party/WebKit/Source/core/animation/KeyframeEffect.idl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/animation/KeyframeEffect.cpp

diff --git a/third_party/WebKit/Source/core/animation/KeyframeEffect.cpp b/third_party/WebKit/Source/core/animation/KeyframeEffect.cpp

index 5d480edfc656d7ccdf24d6886d5609b8ca6e5a16..b598290741fe3e66ad8a24f3f6a89f7bfb2ce8a0 100644

--- a/third_party/WebKit/Source/core/animation/KeyframeEffect.cpp

+++ b/third_party/WebKit/Source/core/animation/KeyframeEffect.cpp

@@ -53,7 +53,7 @@ KeyframeEffect* KeyframeEffect::create(Element* target, EffectModel* model, cons

return new KeyframeEffect(target, model, timing, priority, eventDelegate);

}

-KeyframeEffect* KeyframeEffect::create(ExecutionContext* executionContext, Element* element, const EffectModelOrDictionarySequenceOrDictionary& effectInput, double duration, ExceptionState& exceptionState)

+KeyframeEffect* KeyframeEffect::create(ExecutionContext* executionContext, Element* element, const DictionarySequenceOrDictionary& effectInput, double duration, ExceptionState& exceptionState)

{

ASSERT(RuntimeEnabledFeatures::webAnimationsAPIEnabled());

if (element)

@@ -64,7 +64,7 @@ KeyframeEffect* KeyframeEffect::create(ExecutionContext* executionContext, Eleme

return create(element, EffectInput::convert(element, effectInput, executionContext, exceptionState), timing);

}

+KeyframeEffect* KeyframeEffect::create(ExecutionContext* executionContext, Element* element, const DictionarySequenceOrDictionary& effectInput, const KeyframeEffectOptions& timingInput, ExceptionState& exceptionState)

{

ASSERT(RuntimeEnabledFeatures::webAnimationsAPIEnabled());

if (element)

@@ -76,7 +76,7 @@ KeyframeEffect* KeyframeEffect::create(ExecutionContext* executionContext, Eleme

return create(element, EffectInput::convert(element, effectInput, executionContext, exceptionState), timing);

}

-KeyframeEffect* KeyframeEffect::create(ExecutionContext* executionContext, Element* element, const EffectModelOrDictionarySequenceOrDictionary& effectInput, ExceptionState& exceptionState)

+KeyframeEffect* KeyframeEffect::create(ExecutionContext* executionContext, Element* element, const DictionarySequenceOrDictionary& effectInput, ExceptionState& exceptionState)

{

ASSERT(RuntimeEnabledFeatures::webAnimationsAPIEnabled());

if (element)