Prevent degenerate linear gradient instantiation

Prevent degenerate linear gradient instantiation

If the point distance exceeds SkScalar, nasty things tend to happen.

R=reed@google.com
BUG=636194
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2234663002

Committed: https://skia.googlesource.com/skia/+/c52310402c56e535e574a0a53e2355e5350e952d

[f(malita), 2016-08-10 03:06:14]

Description was changed from

==========
Prevent degenerate linear gradient instantiation

If the point distance exceeds SkScalar, nasty things tend to happen.

R=reed@google.com
BUG=636194
==========

to

==========
Prevent degenerate linear gradient instantiation

If the point distance exceeds SkScalar, nasty things tend to happen.

R=reed@google.com
BUG=636194
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2234663002
==========

[f(malita), 2016-08-10 03:39:27]

The CQ bit was checked by fmalita@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-10 03:39:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-10 04:04:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-10 04:04:48]

Dry run: This issue passed the CQ dry run.

[reed1, 2016-08-10 12:14:55]

reed@google.com changed reviewers:
+ fmenozzi@google.com

[reed1, 2016-08-10 12:14:56]

lgtm

[reed1, 2016-08-10 12:15:18]

wonder if we want similar checks/tests for radial etc.

[reed1, 2016-08-10 12:15:59]

reed@google.com changed reviewers:
+ kjlubick@google.com

[reed1, 2016-08-10 12:16:00]

lets hook up with kevin to start writing explicit fuzzers for gradients

[f(malita), 2016-08-10 12:44:46]

On 2016/08/10 12:16:00, reed1 wrote:
> lets hook up with kevin to start writing explicit fuzzers for gradients

Good idea.  I'm sure there's a bunch of other ways to abuse gradients :)

FWIW, this was exposed by Blink relaxing CSS value parsing: now clamping to
float min/max instead of discarding out-of-range values.

(https://codereview.chromium.org/2115923002)

[f(malita), 2016-08-10 12:44:52]

The CQ bit was checked by fmalita@chromium.org

[commit-bot: I haz the power, 2016-08-10 12:44:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-10 12:45:52]

Description was changed from

==========
Prevent degenerate linear gradient instantiation

If the point distance exceeds SkScalar, nasty things tend to happen.

R=reed@google.com
BUG=636194
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2234663002
==========

to

==========
Prevent degenerate linear gradient instantiation

If the point distance exceeds SkScalar, nasty things tend to happen.

R=reed@google.com
BUG=636194
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2234663002

Committed:
https://skia.googlesource.com/skia/+/c52310402c56e535e574a0a53e2355e5350e952d
==========

[commit-bot: I haz the power, 2016-08-10 12:45:53]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/c52310402c56e535e574a0a53e2355e5350e952d