Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 2115923002: Improve numeric value handling in CSS Parser (Closed)

Created:
4 years, 5 months ago by rwlbuis
Modified:
4 years, 4 months ago
Reviewers:
Timothy Loh
CC:
chromium-reviews, blink-reviews-css, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Improve numeric value handling in CSS Parser This patch changes numeric value handling in two ways: 1. Instead of scanning every parsed token for invalid numeric values, only scan tokens of type NumberToken by checking the value on token creation. 2. Do not consider out of range numerical values as invalid but instead clamp to float range. Several tests are rebased because of the change listed under 2. Committed: https://crrev.com/3e82b8ae69b92fcb4596114f517bf9c05a21b87b Cr-Commit-Position: refs/heads/master@{#409175}

Patch Set 1 #

Patch Set 2 : V2 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -79 lines) Patch
M third_party/WebKit/LayoutTests/css-parser/scientific-notation.html View 1 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/css/large-value-csstext-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/svg/css/scientific-numbers-expected.txt View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/svg/css/script-tests/scientific-numbers.js View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/svg/custom/svg-parse-overflow-1-expected.txt View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/svg/custom/svg-parse-overflow-2-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/svg/custom/svg-parse-overflow-3-expected.txt View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/svg/custom/svg-parse-overflow-4-expected.txt View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/svg/custom/svg-parse-overflow-5-expected.txt View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/svg/dom/length-list-parser-expected.txt View 1 24 chunks +46 lines, -35 lines 0 comments Download
M third_party/WebKit/Source/core/css/parser/CSSParserFastPaths.cpp View 1 1 chunk +4 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/parser/CSSParserToken.h View 1 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/css/parser/CSSParserToken.cpp View 1 2 chunks +1 line, -12 lines 0 comments Download
M third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp View 1 2 chunks +0 lines, -15 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
rwlbuis
PTAL.
4 years, 4 months ago (2016-08-02 00:09:27 UTC) #4
Timothy Loh
On 2016/08/02 00:09:27, rwlbuis wrote: > PTAL. lgtm
4 years, 4 months ago (2016-08-02 03:53:58 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2115923002/20001
4 years, 4 months ago (2016-08-02 10:12:19 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-02 12:26:51 UTC) #9
commit-bot: I haz the power
4 years, 4 months ago (2016-08-02 12:28:24 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/3e82b8ae69b92fcb4596114f517bf9c05a21b87b
Cr-Commit-Position: refs/heads/master@{#409175}

Powered by Google App Engine
This is Rietveld 408576698