src/effects/gradients/SkGradientShader.cpp - Issue 2234663002: Prevent degenerate linear gradient instantiation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/effects/gradients/SkGradientShader.cpp

Issue 2234663002: Prevent degenerate linear gradient instantiation (Closed) Base URL: https://chromium.googlesource.com/skia.git@master

Patch Set: add a regression test Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/effects/gradients/SkGradientShader.cpp

diff --git a/src/effects/gradients/SkGradientShader.cpp b/src/effects/gradients/SkGradientShader.cpp

index 52fbe81daf454925cefdf472c07b04a5ee81efb9..7ff97b343bdcfe35edc2f8c88170d7c174669cf3 100644

--- a/src/effects/gradients/SkGradientShader.cpp

+++ b/src/effects/gradients/SkGradientShader.cpp

@@ -790,7 +790,7 @@ sk_sp<SkShader> SkGradientShader::MakeLinear(const SkPoint pts[2],

SkShader::TileMode mode,

uint32_t flags,

const SkMatrix* localMatrix) {

- if (!pts) {

+ if (!pts || !SkScalarIsFinite((pts[1] - pts[0]).length())) {

return nullptr;

}

if (!valid_grad(colors, pos, colorCount, mode)) {

« no previous file with comments | « no previous file | tests/GradientTest.cpp » ('j') | no next file with comments »