Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issue 2233593003: Fix layout/ng/PRESUBMIT.py by using array.extend instead of concatenation. (Closed)

Created:
4 years, 4 months ago by Gleb Lanbin
Modified:
4 years, 4 months ago
Reviewers:
ikilpatrick, eae
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix layout/ng/PRESUBMIT.py by using array.extend instead of concatenation. NOTRY=true BUG=635619 Committed: https://crrev.com/b5e5eabd3f8a654e73a3fec608ed264ed968f525 Cr-Commit-Position: refs/heads/master@{#411157}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M third_party/WebKit/Source/core/layout/ng/PRESUBMIT.py View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
Gleb Lanbin
4 years, 4 months ago (2016-08-10 21:50:20 UTC) #2
Gleb Lanbin
4 years, 4 months ago (2016-08-10 21:50:33 UTC) #4
ikilpatrick
lgtm
4 years, 4 months ago (2016-08-10 21:53:47 UTC) #5
eae
LGTM++
4 years, 4 months ago (2016-08-10 21:53:54 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2233593003/1
4 years, 4 months ago (2016-08-10 21:55:53 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-10 22:01:06 UTC) #11
commit-bot: I haz the power
4 years, 4 months ago (2016-08-10 22:03:14 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b5e5eabd3f8a654e73a3fec608ed264ed968f525
Cr-Commit-Position: refs/heads/master@{#411157}

Powered by Google App Engine
This is Rietveld 408576698