third_party/WebKit/Source/core/layout/ng/PRESUBMIT.py - Issue 2233593003: Fix layout/ng/PRESUBMIT.py by using array.extend instead of concatenation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/ng/PRESUBMIT.py

Issue 2233593003: Fix layout/ng/PRESUBMIT.py by using array.extend instead of concatenation. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/core/layout/ng/PRESUBMIT.py

diff --git a/third_party/WebKit/Source/core/layout/ng/PRESUBMIT.py b/third_party/WebKit/Source/core/layout/ng/PRESUBMIT.py

index 0154dd300f48b09ce1cc31d8344a469d39fa8537..0d4f77d87e57d796163dfdc461a3ed07f83b541b 100644

--- a/third_party/WebKit/Source/core/layout/ng/PRESUBMIT.py

+++ b/third_party/WebKit/Source/core/layout/ng/PRESUBMIT.py

@@ -9,6 +9,6 @@ for more details about the presubmit API built into depot_tools.

"""

def CheckChangeOnUpload(input_api, output_api):

- results = []

- results += input_api.canned_checks.CheckPatchFormatted(input_api, output_api)

- return results

+ results = []

+ results.extend(input_api.canned_checks.CheckPatchFormatted(input_api, output_api))

+ return results

« no previous file with comments | « no previous file | no next file » | no next file with comments »