third_party/WebKit/Source/core/layout/ng/PRESUBMIT.py - Issue 2233593003: Fix layout/ng/PRESUBMIT.py by using array.extend instead of concatenation.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/core/layout/ng/PRESUBMIT.py

Issue 2233593003: Fix layout/ng/PRESUBMIT.py by using array.extend instead of concatenation. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 # Copyright 2016 The Chromium Authors. All rights reserved.	1 # Copyright 2016 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4	4

5 """Presubmit script for LayoutNG.	5 """Presubmit script for LayoutNG.

6	6

7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts	7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts

8 for more details about the presubmit API built into depot_tools.	8 for more details about the presubmit API built into depot_tools.

9 """	9 """

10	10

11 def CheckChangeOnUpload(input_api, output_api):	11 def CheckChangeOnUpload(input_api, output_api):

12 results = []	12 results = []

13 results += input_api.canned_checks.CheckPatchFormatted(input_api, output_api)	13 results.extend(input_api.canned_checks.CheckPatchFormatted(input_api, output _api))

14 return results	14 return results

OLD	NEW

« no previous file with comments | « no previous file | no next file » | no next file with comments »