Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Unified Diff: components/offline_pages/background/request_queue_unittest.cc

Issue 2233493003: [Offline Pages] Remove expired requests from the queue. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixing patching error. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/offline_pages/background/request_queue_unittest.cc
diff --git a/components/offline_pages/background/request_queue_unittest.cc b/components/offline_pages/background/request_queue_unittest.cc
index 967257c6d83c047573e7cac7a124d32bf3fc7125..ffc3857f60615e42caada2651d0e1f37b5995d3a 100644
--- a/components/offline_pages/background/request_queue_unittest.cc
+++ b/components/offline_pages/background/request_queue_unittest.cc
@@ -175,6 +175,39 @@ TEST_F(RequestQueueTest, RemoveRequest) {
ASSERT_EQ(0ul, last_requests().size());
}
+TEST_F(RequestQueueTest, RemoveRequestByIds) {
+ base::Time creation_time = base::Time::Now();
+ SavePageRequest request(kRequestId, kUrl, kClientId, creation_time,
+ kUserRequested);
+ queue()->AddRequest(request, base::Bind(&RequestQueueTest::AddRequestDone,
+ base::Unretained(this)));
+ PumpLoop();
+
+ SavePageRequest request2(kRequestId2, kUrl2, kClientId2, creation_time,
+ kUserRequested);
+ queue()->AddRequest(request2, base::Bind(&RequestQueueTest::AddRequestDone,
+ base::Unretained(this)));
+ PumpLoop();
+
+ queue()->GetRequests(
+ base::Bind(&RequestQueueTest::GetRequestsDone, base::Unretained(this)));
+ PumpLoop();
+ ASSERT_EQ(GetRequestsResult::SUCCESS, last_get_requests_result());
+ ASSERT_EQ(2ul, last_requests().size());
+
+ queue()->RemoveRequestsById(
+ std::vector<int64_t>({kRequestId, kRequestId2}),
+ base::Bind(&RequestQueueTest::RemoveRequestDone, base::Unretained(this)));
+ PumpLoop();
+ ASSERT_EQ(UpdateRequestResult::SUCCESS, last_remove_result());
+
+ queue()->GetRequests(
+ base::Bind(&RequestQueueTest::GetRequestsDone, base::Unretained(this)));
+ PumpLoop();
+ ASSERT_EQ(GetRequestsResult::SUCCESS, last_get_requests_result());
+ ASSERT_EQ(0ul, last_requests().size());
+}
+
TEST_F(RequestQueueTest, RemoveRequestByClientId) {
base::Time creation_time = base::Time::Now();
// Put two requests on the queue with different client IDs.

Powered by Google App Engine
This is Rietveld 408576698