Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Side by Side Diff: components/offline_pages/background/request_queue_unittest.cc

Issue 2233493003: [Offline Pages] Remove expired requests from the queue. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixing patching error. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/offline_pages/background/request_queue.h" 5 #include "components/offline_pages/background/request_queue.h"
6 6
7 #include <memory> 7 #include <memory>
8 8
9 #include "base/bind.h" 9 #include "base/bind.h"
10 #include "base/test/test_simple_task_runner.h" 10 #include "base/test/test_simple_task_runner.h"
(...skipping 157 matching lines...) Expand 10 before | Expand all | Expand 10 after
168 PumpLoop(); 168 PumpLoop();
169 ASSERT_EQ(UpdateRequestResult::SUCCESS, last_remove_result()); 169 ASSERT_EQ(UpdateRequestResult::SUCCESS, last_remove_result());
170 170
171 queue()->GetRequests( 171 queue()->GetRequests(
172 base::Bind(&RequestQueueTest::GetRequestsDone, base::Unretained(this))); 172 base::Bind(&RequestQueueTest::GetRequestsDone, base::Unretained(this)));
173 PumpLoop(); 173 PumpLoop();
174 ASSERT_EQ(GetRequestsResult::SUCCESS, last_get_requests_result()); 174 ASSERT_EQ(GetRequestsResult::SUCCESS, last_get_requests_result());
175 ASSERT_EQ(0ul, last_requests().size()); 175 ASSERT_EQ(0ul, last_requests().size());
176 } 176 }
177 177
178 TEST_F(RequestQueueTest, RemoveRequestByIds) {
179 base::Time creation_time = base::Time::Now();
180 SavePageRequest request(kRequestId, kUrl, kClientId, creation_time,
181 kUserRequested);
182 queue()->AddRequest(request, base::Bind(&RequestQueueTest::AddRequestDone,
183 base::Unretained(this)));
184 PumpLoop();
185
186 SavePageRequest request2(kRequestId2, kUrl2, kClientId2, creation_time,
187 kUserRequested);
188 queue()->AddRequest(request2, base::Bind(&RequestQueueTest::AddRequestDone,
189 base::Unretained(this)));
190 PumpLoop();
191
192 queue()->GetRequests(
193 base::Bind(&RequestQueueTest::GetRequestsDone, base::Unretained(this)));
194 PumpLoop();
195 ASSERT_EQ(GetRequestsResult::SUCCESS, last_get_requests_result());
196 ASSERT_EQ(2ul, last_requests().size());
197
198 queue()->RemoveRequestsById(
199 std::vector<int64_t>({kRequestId, kRequestId2}),
200 base::Bind(&RequestQueueTest::RemoveRequestDone, base::Unretained(this)));
201 PumpLoop();
202 ASSERT_EQ(UpdateRequestResult::SUCCESS, last_remove_result());
203
204 queue()->GetRequests(
205 base::Bind(&RequestQueueTest::GetRequestsDone, base::Unretained(this)));
206 PumpLoop();
207 ASSERT_EQ(GetRequestsResult::SUCCESS, last_get_requests_result());
208 ASSERT_EQ(0ul, last_requests().size());
209 }
210
178 TEST_F(RequestQueueTest, RemoveRequestByClientId) { 211 TEST_F(RequestQueueTest, RemoveRequestByClientId) {
179 base::Time creation_time = base::Time::Now(); 212 base::Time creation_time = base::Time::Now();
180 // Put two requests on the queue with different client IDs. 213 // Put two requests on the queue with different client IDs.
181 SavePageRequest request(kRequestId, kUrl, kClientId, creation_time, 214 SavePageRequest request(kRequestId, kUrl, kClientId, creation_time,
182 kUserRequested); 215 kUserRequested);
183 queue()->AddRequest(request, base::Bind(&RequestQueueTest::AddRequestDone, 216 queue()->AddRequest(request, base::Bind(&RequestQueueTest::AddRequestDone,
184 base::Unretained(this))); 217 base::Unretained(this)));
185 SavePageRequest request2(kRequestId2, kUrl2, kClientId2, creation_time, 218 SavePageRequest request2(kRequestId2, kUrl2, kClientId2, creation_time,
186 kUserRequested); 219 kUserRequested);
187 queue()->AddRequest(request2, base::Bind(&RequestQueueTest::AddRequestDone, 220 queue()->AddRequest(request2, base::Bind(&RequestQueueTest::AddRequestDone,
(...skipping 100 matching lines...) Expand 10 before | Expand all | Expand 10 after
288 321
289 // Try to update request1 when only request2 is in the queue. 322 // Try to update request1 when only request2 is in the queue.
290 queue()->UpdateRequest( 323 queue()->UpdateRequest(
291 request1, 324 request1,
292 base::Bind(&RequestQueueTest::UpdateRequestDone, base::Unretained(this))); 325 base::Bind(&RequestQueueTest::UpdateRequestDone, base::Unretained(this)));
293 PumpLoop(); 326 PumpLoop();
294 ASSERT_EQ(UpdateRequestResult::REQUEST_DOES_NOT_EXIST, last_update_result()); 327 ASSERT_EQ(UpdateRequestResult::REQUEST_DOES_NOT_EXIST, last_update_result());
295 } 328 }
296 329
297 } // namespace offline_pages 330 } // namespace offline_pages
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698