Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1532)

Unified Diff: components/offline_pages/background/request_queue.cc

Issue 2233493003: [Offline Pages] Remove expired requests from the queue. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixing patching error. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/offline_pages/background/request_queue.cc
diff --git a/components/offline_pages/background/request_queue.cc b/components/offline_pages/background/request_queue.cc
index fd4cc54a982b8047e3dad86a2683605782148880..f32041c86e2bea510a5ad088d5e56829ab5860ba 100644
--- a/components/offline_pages/background/request_queue.cc
+++ b/components/offline_pages/background/request_queue.cc
@@ -53,7 +53,7 @@ void UpdateRequestDone(const RequestQueue::UpdateRequestCallback& callback,
void RemoveRequestDone(const RequestQueue::UpdateRequestCallback& callback,
bool success,
int deleted_requests_count) {
- DCHECK_EQ(1, deleted_requests_count);
+ // DCHECK_EQ(1, deleted_requests_count);
RequestQueue::UpdateRequestResult result =
success ? RequestQueue::UpdateRequestResult::SUCCESS
: RequestQueue::UpdateRequestResult::STORE_FAILURE;
@@ -135,6 +135,11 @@ void RequestQueue::RemoveRequest(int64_t request_id,
store_->RemoveRequests(request_ids, base::Bind(RemoveRequestDone, callback));
}
+void RequestQueue::RemoveRequestsById(std::vector<int64_t> request_ids,
+ const UpdateRequestCallback& callback) {
+ store_->RemoveRequests(request_ids, base::Bind(RemoveRequestDone, callback));
+}
+
void RequestQueue::RemoveRequestsByClientId(
const std::vector<ClientId>& client_ids,
const UpdateRequestCallback& callback) {

Powered by Google App Engine
This is Rietveld 408576698