Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 2233043002: Add a full clear method to GrDrawTarget. (Closed)

Created:
4 years, 4 months ago by bsalomon
Modified:
4 years, 4 months ago
Reviewers:
robertphillips
CC:
reviews_skia.org
Base URL:
https://chromium.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Add a full clear method to GrDrawTarget. This will allow us to avoid ClearBatch creation for successive clears. GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2233043002 Committed: https://skia.googlesource.com/skia/+/9f129de595053a641828b73a8f563dcbae3f034d

Patch Set 1 #

Total comments: 1

Patch Set 2 : include order #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -0 lines) Patch
M src/gpu/GrDrawContext.cpp View 2 chunks +4 lines, -0 lines 0 comments Download
M src/gpu/GrDrawTarget.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/gpu/GrDrawTarget.cpp View 1 2 chunks +12 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 12 (7 generated)
bsalomon
4 years, 4 months ago (2016-08-10 18:23:56 UTC) #3
robertphillips
lgtm https://codereview.chromium.org/2233043002/diff/1/src/gpu/GrDrawTarget.cpp File src/gpu/GrDrawTarget.cpp (right): https://codereview.chromium.org/2233043002/diff/1/src/gpu/GrDrawTarget.cpp#newcode29 src/gpu/GrDrawTarget.cpp:29: #include "batches/GrClearStencilClipBatch.h" up one line ?
4 years, 4 months ago (2016-08-10 18:33:52 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2233043002/1
4 years, 4 months ago (2016-08-10 19:29:55 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2233043002/20001
4 years, 4 months ago (2016-08-10 19:30:42 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-08-10 23:31:08 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/9f129de595053a641828b73a8f563dcbae3f034d

Powered by Google App Engine
This is Rietveld 408576698