Avoid creating full screen clear batches when there is already one in the queue.

Avoid creating full screen clear batches when there is already one in the queue.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2237633003

Committed: https://skia.googlesource.com/skia/+/fd8d013f0da10d94b43fb63002e56a3f4cd7f56d

[bsalomon, 2016-08-10 21:11:24]

Description was changed from

==========
Avoid creating full screen clear batches when there is already one in the queue.
==========

to

==========
Avoid creating full screen clear batches when there is already one in the queue.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2237633003
==========

[bsalomon, 2016-08-11 15:31:43]

bsalomon@google.com changed reviewers:
+ robertphillips@google.com

[bsalomon, 2016-08-11 15:31:43]

Android is pretty noisy, but on my desktop when running nanobench on a skp
capture of the overdraw benchmark I see a reduction from ~320us to ~240us.

[robertphillips, 2016-08-11 16:51:53]

lgtm + suggestion

I'm surprised this makes that big of a difference on desktop. It does highlight
the need for more of this fast pathing though.

https://codereview.chromium.org/2237633003/diff/20001/src/gpu/batches/GrClear...
File src/gpu/batches/GrClearBatch.h (right):

https://codereview.chromium.org/2237633003/diff/20001/src/gpu/batches/GrClear...
src/gpu/batches/GrClearBatch.h:20: 
Why not "sk_sp<GrClearBatch> Make(" ?

[bsalomon, 2016-08-11 17:51:28]

Rerunning the perf the gain is more modest but still very significant 250->210.

https://codereview.chromium.org/2237633003/diff/20001/src/gpu/batches/GrClear...
File src/gpu/batches/GrClearBatch.h (right):

https://codereview.chromium.org/2237633003/diff/20001/src/gpu/batches/GrClear...
src/gpu/batches/GrClearBatch.h:20: 
On 2016/08/11 16:51:53, robertphillips wrote:
> Why not "sk_sp<GrClearBatch> Make(" ?

Done. I thought it'd be more painful than it actually is to mix sk_sp<GrBatch>
and sk_sp<GrClearBatch>

[bsalomon, 2016-08-11 17:51:35]

The CQ bit was checked by bsalomon@google.com

[bsalomon, 2016-08-11 17:51:36]

The patchset sent to the CQ was uploaded after l-g-t-m from
robertphillips@google.com
Link to the patchset: https://codereview.chromium.org/2237633003/#ps40001
(title: "use sk_sp<GrClearBatch>")

[commit-bot: I haz the power, 2016-08-11 17:51:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-11 18:25:35]

Description was changed from

==========
Avoid creating full screen clear batches when there is already one in the queue.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2237633003
==========

to

==========
Avoid creating full screen clear batches when there is already one in the queue.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2237633003

Committed:
https://skia.googlesource.com/skia/+/fd8d013f0da10d94b43fb63002e56a3f4cd7f56d
==========

[commit-bot: I haz the power, 2016-08-11 18:25:36]

Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/fd8d013f0da10d94b43fb63002e56a3f4cd7f56d