services/ui: Inject GpuService instance where needed, instead of singleton.

services/ui: Inject GpuService instance where needed, instead of singleton.

ui::GLES2Context uses the GpuService instance to establish a channel to the GPU
process. Instead of using the global singleton, pass through the GpuService
instance to ui::GLES2Context through the ui::OutputSurface. This removes the
last usage of the GpuService singleton, which means this code can be moved into
the client-lib, where it belongs.

BUG=634377
TBR=ben@ for change related to new API in content/renderer

Committed: https://crrev.com/62c311322b6343e6fd148f9b81d500e795242228
Cr-Commit-Position: refs/heads/master@{#411262}

[sadrul, 2016-08-11 01:12:23]

The CQ bit was checked by sadrul@chromium.org to run a CQ dry run

[sadrul, 2016-08-11 01:12:56]

sadrul@chromium.org changed reviewers:
+ sky@chromium.org

[commit-bot: I haz the power, 2016-08-11 01:13:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-11 02:43:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-11 02:43:11]

Dry run: This issue passed the CQ dry run.

[sky, 2016-08-11 03:28:29]

I think your nickname should be something like 'removes singletons' ;) LGTM

[sadrul, 2016-08-11 04:00:22]

Description was changed from

==========
services/ui: Inject GpuService instance where needed, instead of singleton.

ui::GLES2Context uses the GpuService instance to establish a channel to the GPU
process. Instead of using the global singleton, pass through the GpuService
instance to ui::GLES2Context through the ui::OutputSurface. This removes the
last usage of the GpuService singleton, which means this code can be moved into
the client-lib, where it belongs.

BUG=634377
==========

to

==========
services/ui: Inject GpuService instance where needed, instead of singleton.

ui::GLES2Context uses the GpuService instance to establish a channel to the GPU
process. Instead of using the global singleton, pass through the GpuService
instance to ui::GLES2Context through the ui::OutputSurface. This removes the
last usage of the GpuService singleton, which means this code can be moved into
the client-lib, where it belongs.

BUG=634377
TBR=ben@ for change related to new API in content/renderer
==========

[sadrul, 2016-08-11 04:00:22]

sadrul@chromium.org changed reviewers:
+ ben@chromium.org

[sadrul, 2016-08-11 04:09:19]

TBR'ing ben@ for change related to new API in content/renderer

On 2016/08/11 03:28:29, sky wrote:
> I think your nickname should be something like 'removes singletons' ;) LGTM

penance for singletons I have added in past life :)

[sadrul, 2016-08-11 04:09:39]

The CQ bit was checked by sadrul@chromium.org

[commit-bot: I haz the power, 2016-08-11 04:09:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-11 04:13:32]

Description was changed from

==========
services/ui: Inject GpuService instance where needed, instead of singleton.

ui::GLES2Context uses the GpuService instance to establish a channel to the GPU
process. Instead of using the global singleton, pass through the GpuService
instance to ui::GLES2Context through the ui::OutputSurface. This removes the
last usage of the GpuService singleton, which means this code can be moved into
the client-lib, where it belongs.

BUG=634377
TBR=ben@ for change related to new API in content/renderer
==========

to

==========
services/ui: Inject GpuService instance where needed, instead of singleton.

ui::GLES2Context uses the GpuService instance to establish a channel to the GPU
process. Instead of using the global singleton, pass through the GpuService
instance to ui::GLES2Context through the ui::OutputSurface. This removes the
last usage of the GpuService singleton, which means this code can be moved into
the client-lib, where it belongs.

BUG=634377
TBR=ben@ for change related to new API in content/renderer
==========

[commit-bot: I haz the power, 2016-08-11 04:13:33]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-11 04:15:16]

Description was changed from

==========
services/ui: Inject GpuService instance where needed, instead of singleton.

ui::GLES2Context uses the GpuService instance to establish a channel to the GPU
process. Instead of using the global singleton, pass through the GpuService
instance to ui::GLES2Context through the ui::OutputSurface. This removes the
last usage of the GpuService singleton, which means this code can be moved into
the client-lib, where it belongs.

BUG=634377
TBR=ben@ for change related to new API in content/renderer
==========

to

==========
services/ui: Inject GpuService instance where needed, instead of singleton.

ui::GLES2Context uses the GpuService instance to establish a channel to the GPU
process. Instead of using the global singleton, pass through the GpuService
instance to ui::GLES2Context through the ui::OutputSurface. This removes the
last usage of the GpuService singleton, which means this code can be moved into
the client-lib, where it belongs.

BUG=634377
TBR=ben@ for change related to new API in content/renderer

Committed: https://crrev.com/62c311322b6343e6fd148f9b81d500e795242228
Cr-Commit-Position: refs/heads/master@{#411262}
==========

[commit-bot: I haz the power, 2016-08-11 04:15:18]

Patchset 2 (id:??) landed as
https://crrev.com/62c311322b6343e6fd148f9b81d500e795242228
Cr-Commit-Position: refs/heads/master@{#411262}