Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(331)

Side by Side Diff: services/ui/common/gpu_service.h

Issue 2233003003: services/ui: Inject GpuService instance where needed, instead of singleton. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: . Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « content/renderer/render_thread_impl.cc ('k') | services/ui/common/gpu_service.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef SERVICES_UI_COMMON_GPU_SERVICE_H_ 5 #ifndef SERVICES_UI_COMMON_GPU_SERVICE_H_
6 #define SERVICES_UI_COMMON_GPU_SERVICE_H_ 6 #define SERVICES_UI_COMMON_GPU_SERVICE_H_
7 7
8 #include <stdint.h> 8 #include <stdint.h>
9 #include <vector> 9 #include <vector>
10 10
(...skipping 19 matching lines...) Expand all
30 public: 30 public:
31 ~GpuService() override; 31 ~GpuService() override;
32 32
33 gpu::GpuMemoryBufferManager* gpu_memory_buffer_manager() const { 33 gpu::GpuMemoryBufferManager* gpu_memory_buffer_manager() const {
34 return gpu_memory_buffer_manager_.get(); 34 return gpu_memory_buffer_manager_.get();
35 } 35 }
36 36
37 // The GpuService has to be initialized in the main thread before establishing 37 // The GpuService has to be initialized in the main thread before establishing
38 // the gpu channel. 38 // the gpu channel.
39 static std::unique_ptr<GpuService> Initialize(shell::Connector* connector); 39 static std::unique_ptr<GpuService> Initialize(shell::Connector* connector);
40 static GpuService* GetInstance();
41 40
42 // gpu::GpuChannelEstablishFactory: 41 // gpu::GpuChannelEstablishFactory:
43 void EstablishGpuChannel( 42 void EstablishGpuChannel(
44 const gpu::GpuChannelEstablishedCallback& callback) override; 43 const gpu::GpuChannelEstablishedCallback& callback) override;
45 scoped_refptr<gpu::GpuChannelHost> EstablishGpuChannelSync() override; 44 scoped_refptr<gpu::GpuChannelHost> EstablishGpuChannelSync() override;
46 45
47 private: 46 private:
48 friend struct base::DefaultSingletonTraits<GpuService>; 47 friend struct base::DefaultSingletonTraits<GpuService>;
49 48
50 explicit GpuService(shell::Connector* connector); 49 explicit GpuService(shell::Connector* connector);
(...skipping 26 matching lines...) Expand all
77 scoped_refptr<gpu::GpuChannelHost> gpu_channel_; 76 scoped_refptr<gpu::GpuChannelHost> gpu_channel_;
78 std::vector<gpu::GpuChannelEstablishedCallback> establish_callbacks_; 77 std::vector<gpu::GpuChannelEstablishedCallback> establish_callbacks_;
79 base::ConditionVariable establishing_condition_; 78 base::ConditionVariable establishing_condition_;
80 79
81 DISALLOW_COPY_AND_ASSIGN(GpuService); 80 DISALLOW_COPY_AND_ASSIGN(GpuService);
82 }; 81 };
83 82
84 } // namespace ui 83 } // namespace ui
85 84
86 #endif // COMPONENTS_MUS_PUBLIC_CPP_LIB_GPU_SERVICE_CONNECTION_H_ 85 #endif // COMPONENTS_MUS_PUBLIC_CPP_LIB_GPU_SERVICE_CONNECTION_H_
OLDNEW
« no previous file with comments | « content/renderer/render_thread_impl.cc ('k') | services/ui/common/gpu_service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698