Display text prompting user to set screen lock in order to view password in PasswordEntryEditor

Display text prompting user to set screen lock in order to view password in PasswordEntryEditor

This CL modifies the PasswordEntryEditor for devices that do not have a screen lock set by removing the hidden password view and the copy/view buttons and replacing them with a string of text that asks the user to set a screen lock in order to be able to access the password.

BUG=619868

[dozsa, 2016-08-10 14:14:27]

Description was changed from

==========
Display text prompting user to set screen lock in order to view password in
PasswordEntryEditor

This CL modifies the PasswordEntryEditor for devices that do not have a screen
lock set by removing the hidden password view and the copy/view buttons and
replacing them with a string of text that asks the user to set a screbb kick in
order to be able to access the password.

BUG=619868
==========

to

==========
Display text prompting user to set screen lock in order to view password in
PasswordEntryEditor

This CL modifies the PasswordEntryEditor for devices that do not have a screen
lock set by removing the hidden password view and the copy/view buttons and
replacing them with a string of text that asks the user to set a screen lock in
order to be able to access the password.

BUG=619868
==========

[dozsa, 2016-08-10 14:17:03]

dozsa@google.com changed reviewers:
+ twellington@chromium.org, yusufo@chromium.org

[dozsa, 2016-08-10 14:19:10]

Hello Yusuf and Theresa,

Could you please take a look over this CL?

Best,
Paula

[Theresa, 2016-08-12 18:34:28]

https://codereview.chromium.org/2232893002/diff/1/chrome/android/java/res/lay...
File chrome/android/java/res/layout/password_entry_editor_interactive.xml
(right):

https://codereview.chromium.org/2232893002/diff/1/chrome/android/java/res/lay...
chrome/android/java/res/layout/password_entry_editor_interactive.xml:121:
android:layout_marginStart="15dp"
This TextView and password_entry_editor_password share a number of attributes
(textColor, layout_width and height, marginTop and marginStart, and
textAppearance). Please make a new style in styles.xml that they can both
reference and just set style="@style/PasswordEntryEditorTextView" (or something
like that)

https://codereview.chromium.org/2232893002/diff/1/chrome/android/java/res/lay...
chrome/android/java/res/layout/password_entry_editor_interactive.xml:139:
android:textAppearance="?android:attr/textAppearanceMedium"/>
nit: add the space back before the />

https://codereview.chromium.org/2232893002/diff/1/chrome/android/java/res/lay...
chrome/android/java/res/layout/password_entry_editor_interactive.xml:142:
android:id="@+id/password_entry_editor_spacer"
It doesn't look like this id is used anywhere.

https://codereview.chromium.org/2232893002/diff/1/chrome/android/java/strings...
File chrome/android/java/strings/android_chrome_strings.grd (right):

https://codereview.chromium.org/2232893002/diff/1/chrome/android/java/strings...
chrome/android/java/strings/android_chrome_strings.grd:381: <message
name="IDS_PASSWORD_ENTRY_EDITOR_SET_DEVICE_LOCK_PROMPT" desc="Text displayed
when user doesn't have device lock set">
It's a little confusing that the description here is the same for the string
above. I think the string above is a little bit more explanatory, so maybe we
should ask UX if it's okay to resuse it? Otherwise, enhance the description so
it's clear how these two differ.

[dozsa, 2016-08-18 12:40:37]

https://codereview.chromium.org/2232893002/diff/1/chrome/android/java/res/lay...
File chrome/android/java/res/layout/password_entry_editor_interactive.xml
(right):

https://codereview.chromium.org/2232893002/diff/1/chrome/android/java/res/lay...
chrome/android/java/res/layout/password_entry_editor_interactive.xml:121:
android:layout_marginStart="15dp"
On 2016/08/12 18:34:28, Theresa Wellington wrote:
> This TextView and password_entry_editor_password share a number of attributes
> (textColor, layout_width and height, marginTop and marginStart, and
> textAppearance). Please make a new style in styles.xml that they can both
> reference and just set style="@style/PasswordEntryEditorTextView" (or
something
> like that)

Done.

https://codereview.chromium.org/2232893002/diff/1/chrome/android/java/res/lay...
chrome/android/java/res/layout/password_entry_editor_interactive.xml:139:
android:textAppearance="?android:attr/textAppearanceMedium"/>
On 2016/08/12 18:34:28, Theresa Wellington wrote:
> nit: add the space back before the />

Done.

https://codereview.chromium.org/2232893002/diff/1/chrome/android/java/res/lay...
chrome/android/java/res/layout/password_entry_editor_interactive.xml:142:
android:id="@+id/password_entry_editor_spacer"
On 2016/08/12 18:34:28, Theresa Wellington wrote:
> It doesn't look like this id is used anywhere.

True, I've removed it.

https://codereview.chromium.org/2232893002/diff/1/chrome/android/java/strings...
File chrome/android/java/strings/android_chrome_strings.grd (right):

https://codereview.chromium.org/2232893002/diff/1/chrome/android/java/strings...
chrome/android/java/strings/android_chrome_strings.grd:381: <message
name="IDS_PASSWORD_ENTRY_EDITOR_SET_DEVICE_LOCK_PROMPT" desc="Text displayed
when user doesn't have device lock set">
On 2016/08/12 18:34:28, Theresa Wellington wrote:
> It's a little confusing that the description here is the same for the string
> above. I think the string above is a little bit more explanatory, so maybe we
> should ask UX if it's okay to resuse it? Otherwise, enhance the description so
> it's clear how these two differ.

Ah, sorry, the IDS_PASSWORDS_ACTIVATE_DEVICE_LOCK was also added by me in a CL
that this CL depends on, I've just removed it as after discussions with the UX
designer we've decided to use the latter string.

[Theresa, 2016-08-18 18:10:23]

https://codereview.chromium.org/2232893002/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/preferences/password/PasswordEntryEditor.java
(right):

https://codereview.chromium.org/2232893002/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/preferences/password/PasswordEntryEditor.java:137:
return !ChromeFeatureList.isEnabled(VIEW_PASSWORDS)
If viewing passwords isn't enabled we want to display the interactive password
entry editor?

[dozsa, 2016-08-19 08:03:05]

https://codereview.chromium.org/2232893002/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/preferences/password/PasswordEntryEditor.java
(right):

https://codereview.chromium.org/2232893002/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/preferences/password/PasswordEntryEditor.java:137:
return !ChromeFeatureList.isEnabled(VIEW_PASSWORDS)
On 2016/08/18 18:10:23, Theresa Wellington wrote:
> If viewing passwords isn't enabled we want to display the interactive password
> entry editor?

Sorry, for some reason I wasn't able to change the flag value from the terminal
so I changed it here for testing and forgot to change it back. Changed back to
original now.