Display text prompting user to set screen lock in order to view password in PasswordEntryEditor

chrome/android/java/res/layout/password_entry_editor_interactive.xml

 <?xml version="1.0" encoding="utf-8"?>
 <!-- Copyright 2016 The Chromium Authors. All rights reserved.
      Use of this source code is governed by a BSD-style license that can be
      found in the LICENSE file. -->
 
 <ScrollView xmlns:android="http://schemas.android.com/apk/res/android"
     android:layout_width="match_parent"
     android:layout_height="match_parent"
     android:fillViewport="true" >
 
@@ skipping 93 matching lines @@
         <TextView
             android:text="@string/password_entry_editor_password"
             android:textColor="@color/google_blue_700"
             android:layout_width="wrap_content"
             android:layout_height="wrap_content"
             android:layout_marginTop="5dp"
             android:layout_marginStart="15dp"
             android:gravity="center_vertical"
             android:textAppearance="?android:attr/textAppearanceMedium" />
             
+        <TextView
+            android:id="@+id/password_entry_editor_set_device_lock"
+            android:text="@string/password_entry_editor_set_device_lock_prompt"
+            android:textColor="@color/default_text_color"
+            android:layout_width="match_parent"
+            android:layout_height="match_parent"
+            android:layout_marginTop="10dp"
+            android:layout_marginStart="15dp"

[Theresa, 2016/08/12 18:34:28]

This TextView and password_entry_editor_password share a number of attributes
(textColor, layout_width and height, marginTop and marginStart, and
textAppearance). Please make a new style in styles.xml that they can both
reference and just set style="@style/PasswordEntryEditorTextView" (or something
like that)

[dozsa, 2016/08/18 12:40:37]

Done.

+            android:textAppearance="?android:attr/textAppearanceMedium"
+            android:visibility="gone" />
+            
         <LinearLayout
+            android:id="@+id/password_entry_editor_display_password"
             android:layout_width="wrap_content"
             android:layout_height="wrap_content"
             android:orientation="horizontal">
             
             <TextView
                 android:id="@+id/password_entry_editor_password"
                 android:textColor="@color/default_text_color"
-                android:layout_width="fill_parent"
-                android:layout_height="wrap_content"
+                android:layout_width="match_parent"
+                android:layout_height="match_parent"
                 android:layout_marginTop="10dp"
                 android:layout_marginStart="15dp"
                 android:inputType="textPassword"
-                android:textAppearance="?android:attr/textAppearanceMedium" />
+                android:textAppearance="?android:attr/textAppearanceMedium"/>

[Theresa, 2016/08/12 18:34:28]

nit: add the space back before the />

[dozsa, 2016/08/18 12:40:37]

Done.

             
             <View
+                android:id="@+id/password_entry_editor_spacer"

[Theresa, 2016/08/12 18:34:28]

It doesn't look like this id is used anywhere.

[dozsa, 2016/08/18 12:40:37]

True, I've removed it.

                 android:layout_width="0dp"
                 android:layout_height="0dp"
                 android:layout_weight="1" />
             
             <ImageButton
                 android:id="@+id/password_entry_editor_view_password"
                 android:background="@null"
                 style="?android:attr/buttonStyleSmall"
                 android:layout_width="match_parent"
                 android:layout_height="wrap_content"
@@ skipping 13 matching lines @@
                 android:layout_marginTop="10dp"
                 android:layout_marginEnd="15dp"
                 android:src="@drawable/ic_content_copy"
                 android:contentDescription="@string/password_entry_editor_copy_stored_password" />
         
         </LinearLayout>
 
     </LinearLayout>
 
 </ScrollView>