Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3847)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/preferences/password/PasswordEntryEditor.java

Issue 2232893002: Display text prompting user to set screen lock in order to view password in PasswordEntryEditor Base URL: https://chromium.googlesource.com/chromium/src.git@reauthentication
Patch Set: Revert display condition Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/preferences/password/PasswordEntryEditor.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/preferences/password/PasswordEntryEditor.java b/chrome/android/java/src/org/chromium/chrome/browser/preferences/password/PasswordEntryEditor.java
index 27de3c8ea408201543974afd29f9f99002265119..11e57fd78943f668cf23db4dbd3851ba3a764093 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/preferences/password/PasswordEntryEditor.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/preferences/password/PasswordEntryEditor.java
@@ -22,6 +22,7 @@ import android.view.View;
import android.view.ViewGroup;
import android.widget.Button;
import android.widget.ImageButton;
+import android.widget.LinearLayout;
import android.widget.TextView;
import org.chromium.base.VisibleForTesting;
@@ -114,7 +115,16 @@ public class PasswordEntryEditor extends Fragment {
| InputType.TYPE_TEXT_VARIATION_PASSWORD);
}
if (displayInteractivePasswordEntryEditor()) {
- hookupPasswordButtons();
+ if (mKeyguardManager.isKeyguardSecure()) {
+ hookupPasswordButtons();
+ } else {
+ TextView setDeviceLock = (TextView)
+ mView.findViewById(R.id.password_entry_editor_set_device_lock);
+ setDeviceLock.setVisibility(View.VISIBLE);
+ LinearLayout displayPassword = (LinearLayout)
+ mView.findViewById(R.id.password_entry_editor_display_password);
+ displayPassword.setVisibility(View.GONE);
+ }
hookupCopyUsernameButton();
hookupCopySiteButton();
} else {
« no previous file with comments | « chrome/android/java/res/values-v21/styles.xml ('k') | chrome/android/java/strings/android_chrome_strings.grd » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698