Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Issue 2232723004: Revert of Use iossim/test-without-building for Earlgrey tests. (Closed)

Created:
4 years, 4 months ago by huangml1
Modified:
4 years, 4 months ago
Reviewers:
baxley, jbudorick, smut
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Revert of Use iossim/test-without-building for Earlgrey tests. (patchset #5 id:100001 of https://codereview.chromium.org/2229183002/ ) Reason for revert: Broke downstream eg bots since downstream change not landed. Original issue's description: > Use iossim/test-without-building for Earlgrey tests. > > XCtests work with iossim/test-without-building in xcode 8. > Remove the usage of the dummy test runner. > > BUG= > > Committed: https://chromium.googlesource.com/chromium/tools/build/+/12b302b6ed29f15838a9145262d7913d19ae4aba TBR=smut@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://chromium.googlesource.com/chromium/tools/build/+/ba41e09fdee7169b88c2ce65662da52e20301212

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -56 lines) Patch
M scripts/slave/ios/run.py View 4 chunks +17 lines, -10 lines 0 comments Download
M scripts/slave/ios/test_runner.py View 14 chunks +43 lines, -35 lines 0 comments Download
M scripts/slave/recipe_modules/ios/api.py View 1 chunk +3 lines, -6 lines 0 comments Download
M scripts/slave/recipes/ios/unified_builder_tester.py View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/ios/unified_builder_tester.expected/basic.json View 3 chunks +6 lines, -4 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
huangml1
Created Revert of Use iossim/test-without-building for Earlgrey tests.
4 years, 4 months ago (2016-08-10 19:40:32 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2232723004/1
4 years, 4 months ago (2016-08-10 19:40:36 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 4 months ago (2016-08-10 19:40:37 UTC) #5
baxley
+jbudorick as a commiter, and this is a revert
4 years, 4 months ago (2016-08-10 20:58:43 UTC) #7
jbudorick
lgtm stamp
4 years, 4 months ago (2016-08-10 20:59:25 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2232723004/1
4 years, 4 months ago (2016-08-10 21:01:57 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/tools/build/+/ba41e09fdee7169b88c2ce65662da52e20301212
4 years, 4 months ago (2016-08-10 21:02:18 UTC) #12
baxley
On 2016/08/10 21:02:18, commit-bot: I haz the power wrote: > Committed patchset #1 (id:1) as ...
4 years, 4 months ago (2016-08-11 01:38:51 UTC) #13
smut
4 years, 4 months ago (2016-08-11 21:42:22 UTC) #14
Message was sent while issue was closed.
On 2016/08/11 01:38:51, baxley wrote:
> On 2016/08/10 21:02:18, commit-bot: I haz the power wrote:
> > Committed patchset #1 (id:1) as
> >
>
https://chromium.googlesource.com/chromium/tools/build/+/ba41e09fdee7169b88c2...
> 
> Hi Sana,
> 
> Do we need to do anything to roll the recipe changes? Or do we have to do
> something to restart the downstream bots for this change to take effect?
> 
> Thanks!
> -Mike

The infra scripts on downstream iOS Swarming bots need to be updated manually to
take effect. This'll be fixed soon.

Powered by Google App Engine
This is Rietveld 408576698