Use iossim/test-without-building for Earlgrey tests.

Use iossim/test-without-building for Earlgrey tests.

XCtests work with iossim/test-without-building in xcode 8.
Remove the usage of the dummy test runner.

BUG=

Committed: https://chromium.googlesource.com/chromium/tools/build/+/12b302b6ed29f15838a9145262d7913d19ae4aba

[huangml1, 2016-08-09 23:25:35]

huangml@chromium.org changed reviewers:
+ smut@google.com

[huangml1, 2016-08-09 23:25:36]

Change the upstream to use iossim Earlgrey tests in simulators. PTAL, thanks!

[huangml1, 2016-08-09 23:52:48]

Patchset #2 (id:20001) has been deleted

[smut, 2016-08-09 23:54:54]

https://codereview.chromium.org/2229183002/diff/40001/scripts/slave/ios/run.py
File scripts/slave/ios/run.py (right):

https://codereview.chromium.org/2229183002/diff/40001/scripts/slave/ios/run.p...
scripts/slave/ios/run.py:101: )
Unused? Remove if unused.

https://codereview.chromium.org/2229183002/diff/40001/scripts/slave/ios/run.p...
scripts/slave/ios/run.py:145: )
Where is this used?

[huangml1, 2016-08-09 23:58:23]

https://codereview.chromium.org/2229183002/diff/40001/scripts/slave/ios/run.py
File scripts/slave/ios/run.py (right):

https://codereview.chromium.org/2229183002/diff/40001/scripts/slave/ios/run.p...
scripts/slave/ios/run.py:101: )
On 2016/08/09 23:54:54, smut wrote:
> Unused? Remove if unused.

Done.

https://codereview.chromium.org/2229183002/diff/40001/scripts/slave/ios/run.p...
scripts/slave/ios/run.py:145: )
On 2016/08/09 23:54:54, smut wrote:
> Where is this used?

This is used for the DeviceXCTestRunner.  The device thing is running downstream
only but most methods are upstream, so I added the argument here.

[smut, 2016-08-10 00:03:55]

https://codereview.chromium.org/2229183002/diff/40001/scripts/slave/ios/run.py
File scripts/slave/ios/run.py (right):

https://codereview.chromium.org/2229183002/diff/40001/scripts/slave/ios/run.p...
scripts/slave/ios/run.py:145: )
On 2016/08/09 23:58:23, huangml1 wrote:
> On 2016/08/09 23:54:54, smut wrote:
> > Where is this used?
> 
> This is used for the DeviceXCTestRunner.  The device thing is running
downstream
> only but most methods are upstream, so I added the argument here.

The run.py called downstream is not the same as the run.py called upstream. If
you are using it downstream it's okay to add it to test_runner.py (because
downstream subclasses upstream), but it can be removed from run.py.

It's confusing, but I'm working on fixing it up as we transition to Swarming
upstream.

[huangml1, 2016-08-10 00:11:26]

OK! Removed it from run.py

[smut, 2016-08-10 00:15:18]

The CQ bit was checked by smut@google.com

[smut, 2016-08-10 00:15:19]

lgtm

[commit-bot: I haz the power, 2016-08-10 00:15:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-10 00:23:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-10 00:23:15]

Try jobs failed on following builders:
  Build Presubmit on luci.infra.try (JOB_FAILED,
https://luci-milo.appspot.com/swarming/task/308aa2cd30a63010)

[huangml1, 2016-08-10 00:43:32]

The CQ bit was checked by huangml@chromium.org

[huangml1, 2016-08-10 00:43:32]

The patchset sent to the CQ was uploaded after l-g-t-m from smut@google.com
Link to the patchset: https://codereview.chromium.org/2229183002/#ps100001
(title: "Remove unused arg")

[commit-bot: I haz the power, 2016-08-10 00:43:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-10 00:47:42]

Description was changed from

==========
Use iossim/test-without-building for Earlgrey tests.

XCtests work with iossim/test-without-building in xcode 8.
Remove the usage of the dummy test runner.

BUG=
==========

to

==========
Use iossim/test-without-building for Earlgrey tests.

XCtests work with iossim/test-without-building in xcode 8.
Remove the usage of the dummy test runner.

BUG=

Committed:
https://chromium.googlesource.com/chromium/tools/build/+/12b302b6ed29f15838a9...
==========

[commit-bot: I haz the power, 2016-08-10 00:47:43]

Committed patchset #5 (id:100001) as
https://chromium.googlesource.com/chromium/tools/build/+/12b302b6ed29f15838a9...

[huangml1, 2016-08-10 19:40:31]

A revert of this CL (patchset #5 id:100001) has been created in
https://codereview.chromium.org/2232723004/ by huangml@chromium.org.

The reason for reverting is: Broke downstream eg bots since downstream change
not landed. .