Issue 223193005: Get rid of the TRANSITION PropertyType and consistently use CanHoldValue().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 223193005: Get rid of the TRANSITION PropertyType and consistently use CanHoldValue(). (Closed)

Created:
6 years, 8 months ago by Benedikt Meurer

Modified:
6 years, 8 months ago

Reviewers:
Igor Sheludko, Toon Verwaest

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Get rid of the TRANSITION PropertyType and consistently use CanHoldValue(). R=verwaest@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=20494

Patch Set 1 #

Patch Set 2 : Use GetPropertyDetails() instead of GetLastDescriptorDetails(). #

Total comments: 1

Patch Set 3 : Use number_ for LastAdded in transition results. #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+310 lines, -300 lines)			Patch
M	src/bootstrapper.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	src/heap-snapshot-generator.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	src/ic.cc	View	1	3 chunks	+82 lines, -83 lines	0 comments	Download
M	src/objects.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	src/objects.cc	View		11 chunks	+69 lines, -76 lines	0 comments	Download
M	src/objects-inl.h	View		2 chunks	+9 lines, -9 lines	0 comments	Download
M	src/objects-printer.cc	View		3 chunks	+0 lines, -3 lines	0 comments	Download
M	src/property.h	View	1 2	9 chunks	+75 lines, -54 lines	0 comments	Download
M	src/property.cc	View		1 chunk	+55 lines, -53 lines	0 comments	Download
M	src/property-details.h	View		1 chunk	+1 line, -2 lines	0 comments	Download
M	src/runtime.cc	View		3 chunks	+18 lines, -18 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Benedikt Meurer

Hey Igor, This get's rid of the TRANSITION PropertyType, which is used in LookupResult only ...

6 years, 8 months ago (2014-04-03 08:08:08 UTC) #1

Benedikt Meurer

Committed patchset #3 manually as r20494 (presubmit successful).

6 years, 8 months ago (2014-04-04 04:49:20 UTC) #3

Igor Sheludko

6 years, 8 months ago (2014-04-04 15:42:11 UTC) #4

Message was sent while issue was closed.

https://codereview.chromium.org/223193005/diff/20001/src/objects-printer.cc
File src/objects-printer.cc (right):

https://codereview.chromium.org/223193005/diff/20001/src/objects-printer.cc#n...
src/objects-printer.cc:273: // There are no transitions in the descriptor array.
Does this comment still make sense?

Expand Messages | Collapse Messages