Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Side by Side Diff: src/heap-snapshot-generator.cc

Issue 223193005: Get rid of the TRANSITION PropertyType and consistently use CanHoldValue(). (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Use number_ for LastAdded in transition results. Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/bootstrapper.cc ('k') | src/ic.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1638 matching lines...) Expand 10 before | Expand all | Expand 10 after
1649 break; 1649 break;
1650 case CALLBACKS: 1650 case CALLBACKS:
1651 ExtractAccessorPairProperty( 1651 ExtractAccessorPairProperty(
1652 js_obj, entry, 1652 js_obj, entry,
1653 descs->GetKey(i), descs->GetValue(i)); 1653 descs->GetKey(i), descs->GetValue(i));
1654 break; 1654 break;
1655 case NORMAL: // only in slow mode 1655 case NORMAL: // only in slow mode
1656 case HANDLER: // only in lookup results, not in descriptors 1656 case HANDLER: // only in lookup results, not in descriptors
1657 case INTERCEPTOR: // only in lookup results, not in descriptors 1657 case INTERCEPTOR: // only in lookup results, not in descriptors
1658 break; 1658 break;
1659 case TRANSITION:
1660 case NONEXISTENT: 1659 case NONEXISTENT:
1661 UNREACHABLE(); 1660 UNREACHABLE();
1662 break; 1661 break;
1663 } 1662 }
1664 } 1663 }
1665 } else { 1664 } else {
1666 NameDictionary* dictionary = js_obj->property_dictionary(); 1665 NameDictionary* dictionary = js_obj->property_dictionary();
1667 int length = dictionary->Capacity(); 1666 int length = dictionary->Capacity();
1668 for (int i = 0; i < length; ++i) { 1667 for (int i = 0; i < length; ++i) {
1669 Object* k = dictionary->KeyAt(i); 1668 Object* k = dictionary->KeyAt(i);
(...skipping 1476 matching lines...) Expand 10 before | Expand all | Expand 10 after
3146 writer_->AddString("\"<dummy>\""); 3145 writer_->AddString("\"<dummy>\"");
3147 for (int i = 1; i < sorted_strings.length(); ++i) { 3146 for (int i = 1; i < sorted_strings.length(); ++i) {
3148 writer_->AddCharacter(','); 3147 writer_->AddCharacter(',');
3149 SerializeString(sorted_strings[i]); 3148 SerializeString(sorted_strings[i]);
3150 if (writer_->aborted()) return; 3149 if (writer_->aborted()) return;
3151 } 3150 }
3152 } 3151 }
3153 3152
3154 3153
3155 } } // namespace v8::internal 3154 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/bootstrapper.cc ('k') | src/ic.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698