Get rid of the TRANSITION PropertyType and consistently use CanHoldValue().

src/objects-printer.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 252 matching lines @@
           descs->GetConstant(i)->ShortPrint(out);
           PrintF(out, " (constant)\n");
           break;
         case CALLBACKS:
           descs->GetCallbacksObject(i)->ShortPrint(out);
           PrintF(out, " (callback)\n");
           break;
         case NORMAL:  // only in slow mode
         case HANDLER:  // only in lookup results, not in descriptors
         case INTERCEPTOR:  // only in lookup results, not in descriptors
         // There are no transitions in the descriptor array.

[Igor Sheludko, 2014/04/04 15:42:11]

Does this comment still make sense?

-        case TRANSITION:
         case NONEXISTENT:
           UNREACHABLE();
           break;
       }
     }
   } else {
     property_dictionary()->Print(out);
   }
 }
 
@@ skipping 136 matching lines @@
         case CONSTANT:
           PrintF(out, " (transition to constant)\n");
           break;
         case CALLBACKS:
           PrintF(out, " (transition to callback)\n");
           break;
         // Values below are never in the target descriptor array.
         case NORMAL:
         case HANDLER:
         case INTERCEPTOR:
-        case TRANSITION:
         case NONEXISTENT:
           UNREACHABLE();
           break;
       }
     }
   }
 }
 
 
 void JSObject::JSObjectPrint(FILE* out) {
@@ skipping 774 matching lines @@
       case CONSTANT:
         PrintF(out, " (transition to constant)\n");
         break;
       case CALLBACKS:
         PrintF(out, " (transition to callback)\n");
         break;
       // Values below are never in the target descriptor array.
       case NORMAL:
       case HANDLER:
       case INTERCEPTOR:
-      case TRANSITION:
       case NONEXISTENT:
         UNREACHABLE();
         break;
     }
   }
   PrintF(out, "\n");
 }
 
 
 #endif  // OBJECT_PRINT
 
 
 } }  // namespace v8::internal