Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(531)

Issue 2231753002: components: Use stl utilities from the base namespace (Closed)

Created:
4 years, 4 months ago by Sami
Modified:
4 years, 4 months ago
Reviewers:
Cait (Slow)
CC:
chromium-reviews, rsleevi+watch_chromium.org, certificate-transparency-chrome_googlegroups.com, msramek+watch_chromium.org, sadrul, Eran Messeri, browser-components-watch_chromium.org, markusheintz_, jam, raymes+watch_chromium.org, darin-cc_chromium.org, devtools-reviews_chromium.org, vabr+watchlistautofill_chromium.org, kalyank, mlamouri+watch-content_chromium.org, vabr+watchlistpasswordmanager_chromium.org, rouslan+autofill_chromium.org, asvitkine+watch_chromium.org, gcasto+watchlist_chromium.org, sync-reviews_chromium.org, jdonnelly+autofillwatch_chromium.org, estade+watch_chromium.org, pfeldman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

components: Use stl utilities from the base namespace The utilities in base/stl_util.h have been moved from the global into the base namespace. This patch updates the call sites accordingly. No functional changes. This patch was generated with the following script: https://drive.google.com/open?id=0ByyxMXB38gLDNXJFaUdVbjhoemM BUG=636301 Committed: https://crrev.com/463844102453da60bf5f4a54dd2f1be55856dee5 Cr-Commit-Position: refs/heads/master@{#411644}

Patch Set 1 #

Patch Set 2 : Android/CrOS changes #

Patch Set 3 : Android/CrOS changes #

Patch Set 4 : Mac/Win fixes #

Patch Set 5 : Rebased #

Patch Set 6 : One more call site #

Unified diffs Side-by-side diffs Delta from patch set Stats (+243 lines, -229 lines) Patch
M components/autofill/content/renderer/form_autofill_util.cc View 3 chunks +7 lines, -5 lines 0 comments Download
M components/autofill/content/renderer/form_cache.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/core/browser/autofill_country.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/autofill/core/browser/autofill_download_manager.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/autofill/core/browser/autofill_external_delegate.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M components/autofill/core/browser/phone_field_unittest.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/core/browser/webdata/autofill_table.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/core/browser/webdata/autofill_table_unittest.cc View 9 chunks +9 lines, -9 lines 0 comments Download
M components/autofill/core/browser/webdata/autofill_webdata_backend_impl.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/autofill/core/browser/webdata/web_data_service_unittest.cc View 10 chunks +10 lines, -10 lines 0 comments Download
M components/certificate_transparency/log_proof_fetcher.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/content_settings/core/browser/content_settings_info.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/content_settings/core/browser/content_settings_registry.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M components/content_settings/core/browser/host_content_settings_map.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M components/content_settings/core/common/content_settings.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M components/crash/content/browser/crash_dump_manager_android.cc View 1 chunk +2 lines, -1 line 0 comments Download
M components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_protocol_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M components/data_reduction_proxy/core/browser/data_reduction_proxy_config.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/devtools_discovery/devtools_discovery_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/devtools_http_handler/devtools_http_handler.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M components/domain_reliability/context.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/domain_reliability/dispatcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/domain_reliability/google_configs_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/domain_reliability/monitor_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/domain_reliability/uploader.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/drive/chromeos/directory_loader.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M components/drive/file_write_watcher.cc View 1 chunk +2 lines, -1 line 0 comments Download
M components/drive/service/fake_drive_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/feedback/feedback_uploader_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/flags_ui/flags_state.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M components/flags_ui/flags_state_unittest.cc View 4 chunks +9 lines, -9 lines 0 comments Download
M components/guest_view/browser/guest_view_manager.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M components/history/core/browser/download_database.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M components/history/core/browser/history_backend.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M components/history/core/browser/visit_tracker.cc View 1 chunk +2 lines, -1 line 0 comments Download
M components/history/core/browser/web_history_service.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M components/invalidation/impl/registration_manager.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/invalidation/impl/registration_manager_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M components/invalidation/impl/sync_invalidation_listener_unittest.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M components/invalidation/impl/sync_system_resources.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/keyed_service/core/keyed_service_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/keyed_service/core/refcounted_keyed_service_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/metrics/profiler/profiler_metrics_provider.cc View 1 chunk +2 lines, -1 line 0 comments Download
M components/network_session_configurator/network_session_configurator_unittest.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M components/password_manager/core/browser/password_store_default_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/password_manager/core/browser/password_store_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/policy/core/browser/configuration_policy_handler_list.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/policy/core/common/cloud/cloud_policy_client.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M components/policy/core/common/cloud/component_cloud_policy_service_unittest.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M components/policy/core/common/cloud/external_policy_data_fetcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/policy/core/common/cloud/external_policy_data_updater.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/policy/core/common/config_dir_policy_loader.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/policy/core/common/policy_bundle.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/policy/core/common/policy_service_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/policy/core/common/registry_dict_win.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/policy/core/common/schema.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/prefs/pref_notifier_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/prefs/pref_registry.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/proximity_auth/bluetooth_throttler_impl.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/query_parser/query_parser.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/rappor/rappor_service.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M components/safe_browsing_db/database_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/safe_browsing_db/v4_store.cc View 1 2 3 4 3 chunks +5 lines, -4 lines 0 comments Download
M components/search_engines/default_search_policy_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/search_engines/template_url_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/search_engines/template_url_service_util_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/sessions/core/session_service_commands.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/sessions/core/session_types.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/signin/core/browser/about_signin_internals.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/signin/core/browser/account_tracker_service.cc View 8 chunks +8 lines, -8 lines 0 comments Download
M components/spellcheck/renderer/spellcheck.cc View 1 2 3 4 5 1 chunk +2 lines, -2 lines 0 comments Download
M components/storage_monitor/media_transfer_protocol_device_observer_linux.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/storage_monitor/portable_device_watcher_win.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/storage_monitor/storage_monitor.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/storage_monitor/storage_monitor_chromeos.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M components/storage_monitor/storage_monitor_linux.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M components/storage_monitor/transient_device_ids.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/storage_monitor/volume_mount_watcher_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/sync/base/unique_position.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/sync/core_impl/protocol_event_buffer.h View 1 chunk +1 line, -1 line 0 comments Download
M components/sync/engine_impl/get_updates_processor_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/sync/syncable/directory.cc View 4 chunks +7 lines, -6 lines 0 comments Download
M components/sync/syncable/directory_backing_store_unittest.cc View 8 chunks +8 lines, -8 lines 0 comments Download
M components/sync/syncable/on_disk_directory_backing_store.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/sync/syncable/parent_child_index_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/sync/syncable/syncable_delete_journal.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/sync_sessions/synced_session.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/sync_sessions/synced_session_tracker.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/syncable_prefs/pref_model_associator.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/update_client/update_engine.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M components/url_matcher/regex_set_matcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/url_matcher/regex_set_matcher_unittest.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M components/url_matcher/url_matcher.cc View 6 chunks +8 lines, -8 lines 0 comments Download
M components/user_prefs/tracked/segregated_pref_store.cc View 1 chunk +6 lines, -4 lines 0 comments Download
M components/variations/study_filtering.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M components/variations/variations_associated_data.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 32 (26 generated)
Sami
Sorry for the massive patch, but this is entirely mechanical. I can split this down ...
4 years, 4 months ago (2016-08-10 16:41:02 UTC) #11
Cait (Slow)
rubberstamp lgtm I'm assuming there was a script/tool used to generate this CL. Please provide ...
4 years, 4 months ago (2016-08-12 14:19:33 UTC) #24
Sami
On 2016/08/12 14:19:33, Cait (slow) wrote: > rubberstamp lgtm > > I'm assuming there was ...
4 years, 4 months ago (2016-08-12 14:28:05 UTC) #26
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2231753002/100001
4 years, 4 months ago (2016-08-12 14:28:38 UTC) #28
commit-bot: I haz the power
Committed patchset #6 (id:100001)
4 years, 4 months ago (2016-08-12 14:34:09 UTC) #30
commit-bot: I haz the power
4 years, 4 months ago (2016-08-12 14:36:25 UTC) #32
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/463844102453da60bf5f4a54dd2f1be55856dee5
Cr-Commit-Position: refs/heads/master@{#411644}

Powered by Google App Engine
This is Rietveld 408576698