components/policy/core/common/cloud/component_cloud_policy_service_unittest.cc - Issue 2231753002: components: Use stl utilities from the base namespace

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/policy/core/common/cloud/component_cloud_policy_service_unittest.cc

Issue 2231753002: components: Use stl utilities from the base namespace (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: One more call site Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/policy/core/common/cloud/cloud_policy_client.cc ('k') | components/policy/core/common/cloud/external_policy_data_fetcher.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/policy/core/common/cloud/component_cloud_policy_service_unittest.cc

diff --git a/components/policy/core/common/cloud/component_cloud_policy_service_unittest.cc b/components/policy/core/common/cloud/component_cloud_policy_service_unittest.cc

index 80b3734f7e63408b6257e87c4b790d1c11ca6f85..f92c90243752833788f72b3113e759d98f5fbe82 100644

--- a/components/policy/core/common/cloud/component_cloud_policy_service_unittest.cc

+++ b/components/policy/core/common/cloud/component_cloud_policy_service_unittest.cc

@@ -394,7 +394,7 @@ TEST_F(ComponentCloudPolicyServiceTest, LoadAndPurgeCache) {

std::map<std::string, std::string> contents;

cache_->LoadAllSubkeys("extension-policy", &contents);

EXPECT_EQ(1u, contents.size());

- EXPECT_TRUE(ContainsKey(contents, kTestExtension2));

+ EXPECT_TRUE(base::ContainsKey(contents, kTestExtension2));

}

TEST_F(ComponentCloudPolicyServiceTest, SignInAfterStartup) {

@@ -538,8 +538,8 @@ TEST_F(ComponentCloudPolicyServiceTest, PurgeWhenServerRemovesPolicy) {

std::map<std::string, std::string> contents;

cache_->LoadAllSubkeys("extension-policy", &contents);

ASSERT_EQ(2u, contents.size());

- EXPECT_TRUE(ContainsKey(contents, kTestExtension));

- EXPECT_TRUE(ContainsKey(contents, kTestExtension2));

+ EXPECT_TRUE(base::ContainsKey(contents, kTestExtension));

+ EXPECT_TRUE(base::ContainsKey(contents, kTestExtension2));

PolicyBundle expected_bundle;

const PolicyNamespace ns(POLICY_DOMAIN_EXTENSIONS, kTestExtension);

@@ -566,8 +566,8 @@ TEST_F(ComponentCloudPolicyServiceTest, PurgeWhenServerRemovesPolicy) {

contents.clear();

cache_->LoadAllSubkeys("extension-policy", &contents);

ASSERT_EQ(1u, contents.size());

- EXPECT_TRUE(ContainsKey(contents, kTestExtension));

- EXPECT_FALSE(ContainsKey(contents, kTestExtension2));

+ EXPECT_TRUE(base::ContainsKey(contents, kTestExtension));

+ EXPECT_FALSE(base::ContainsKey(contents, kTestExtension2));

// And the service isn't publishing policy for the second extension anymore.

expected_bundle.Clear();