components/autofill/core/browser/autofill_external_delegate.cc - Issue 2231753002: components: Use stl utilities from the base namespace

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/core/browser/autofill_external_delegate.cc

Issue 2231753002: components: Use stl utilities from the base namespace (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: One more call site Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/autofill/core/browser/autofill_download_manager.cc ('k') | components/autofill/core/browser/phone_field_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/core/browser/autofill_external_delegate.cc

diff --git a/components/autofill/core/browser/autofill_external_delegate.cc b/components/autofill/core/browser/autofill_external_delegate.cc

index cf22acfc52995475a58904cafd7cad69b8b6831b..fc526b6581e4bc92ec90b208ed1e2da802585d87 100644

--- a/components/autofill/core/browser/autofill_external_delegate.cc

+++ b/components/autofill/core/browser/autofill_external_delegate.cc

@@ -343,12 +343,12 @@ void AutofillExternalDelegate::InsertDataListValues(

std::set<base::string16> data_list_set(data_list_values_.begin(),

data_list_values_.end());

suggestions->erase(

- std::remove_if(suggestions->begin(), suggestions->end(),

- [&data_list_set](const Suggestion& suggestion) {

- return suggestion.frontend_id ==

- POPUP_ITEM_ID_AUTOCOMPLETE_ENTRY &&

- ContainsKey(data_list_set, suggestion.value);

- }),

+ std::remove_if(

+ suggestions->begin(), suggestions->end(),

+ [&data_list_set](const Suggestion& suggestion) {

+ return suggestion.frontend_id == POPUP_ITEM_ID_AUTOCOMPLETE_ENTRY &&

+ base::ContainsKey(data_list_set, suggestion.value);

+ }),

suggestions->end());

#if !defined(OS_ANDROID)