Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(260)

Issue 2231723002: Fix code signing for iOS bundle when targetting simulator. (Closed)

Created:
4 years, 4 months ago by sdefresne
Modified:
4 years, 4 months ago
Reviewers:
Olivier, justincohen
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix code signing for iOS bundle when targetting simulator. When building for simulator, embedded.mobileprovision should not be copied into the bundle, and not entitlement should be passed to the "codesign" tool. BUG=634373 Committed: https://crrev.com/aa4d65708c18e2b407f92654237ab2c1fdc3cea7 Cr-Commit-Position: refs/heads/master@{#411006}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
M build/config/ios/codesign.py View 3 chunks +5 lines, -2 lines 0 comments Download
M build/config/ios/rules.gni View 3 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
sdefresne
Whoever will be the fastest, please review this and send to CQ. This is required ...
4 years, 4 months ago (2016-08-10 07:14:46 UTC) #4
Olivier
lgtm
4 years, 4 months ago (2016-08-10 07:20:49 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2231723002/1
4 years, 4 months ago (2016-08-10 07:51:19 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-10 08:39:40 UTC) #9
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/aa4d65708c18e2b407f92654237ab2c1fdc3cea7 Cr-Commit-Position: refs/heads/master@{#411006}
4 years, 4 months ago (2016-08-10 08:41:49 UTC) #11
justincohen
4 years, 4 months ago (2016-08-10 14:13:05 UTC) #12
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698