Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Unified Diff: build/config/ios/rules.gni

Issue 2231723002: Fix code signing for iOS bundle when targetting simulator. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/config/ios/codesign.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/config/ios/rules.gni
diff --git a/build/config/ios/rules.gni b/build/config/ios/rules.gni
index 0ffb9e9c600cd3c70c1e75cbb9acb0a6daedb5d0..bbb510bedd535b4e289b4457a31b15ee7e19edd8 100644
--- a/build/config/ios/rules.gni
+++ b/build/config/ios/rules.gni
@@ -480,6 +480,7 @@ template("ios_app_bundle") {
}
code_signing_args = [
"code-sign-bundle",
+ "-t=" + ios_sdk_name,
"-i=" + ios_code_signing_identity,
"-e=" + rebase_path(_entitlements_path, root_build_dir),
"-b=" + rebase_path("$target_out_dir/$_output_name", root_build_dir),
@@ -1174,6 +1175,7 @@ template("ios_framework_bundle") {
}
code_signing_args = [
"code-sign-bundle",
+ "-t=" + ios_sdk_name,
"-i=" + ios_code_signing_identity,
"-e=" + rebase_path(_entitlements_path, root_build_dir),
"-b=" +
@@ -1415,6 +1417,7 @@ template("ios_xctest_test") {
}
code_signing_args = [
"code-sign-bundle",
+ "-t=" + ios_sdk_name,
"-i=" + ios_code_signing_identity,
"-e=" + rebase_path(_entitlements_path, root_build_dir),
"-b=" + rebase_path("$target_out_dir/$_xctest_output", root_build_dir),
« no previous file with comments | « build/config/ios/codesign.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698