Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(778)

Unified Diff: build/config/ios/codesign.py

Issue 2231723002: Fix code signing for iOS bundle when targetting simulator. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | build/config/ios/rules.gni » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/config/ios/codesign.py
diff --git a/build/config/ios/codesign.py b/build/config/ios/codesign.py
index 364640edca45ee0da547d8b67af3807408a9e40d..3d66b246837b4994b675ade0fba033198a087b11 100644
--- a/build/config/ios/codesign.py
+++ b/build/config/ios/codesign.py
@@ -268,6 +268,9 @@ class CodeSignBundleAction(Action):
parser.add_argument(
'--disable-code-signature', action='store_false', dest='sign',
help='disable code signature')
+ parser.add_argument(
+ '--platform', '-t', required=True,
+ help='platform the signed bundle is targetting')
parser.set_defaults(sign=True)
@staticmethod
@@ -283,7 +286,7 @@ class CodeSignBundleAction(Action):
provisioning_profile_required = args.identity != '-'
provisioning_profile = FindProvisioningProfile(
bundle.identifier, provisioning_profile_required)
- if provisioning_profile:
+ if provisioning_profile and args.platform != 'iphonesimulator':
provisioning_profile.Install(bundle)
# Delete existing code signature.
@@ -306,7 +309,7 @@ class CodeSignBundleAction(Action):
# Embeds entitlements into the code signature (if code signing identify has
# been provided).
codesign_extra_args = []
- if provisioning_profile:
+ if provisioning_profile and args.platform != 'iphonesimulator':
temporary_entitlements_file = tempfile.NamedTemporaryFile(suffix='.xcent')
codesign_extra_args.extend(
['--entitlements', temporary_entitlements_file.name])
« no previous file with comments | « no previous file | build/config/ios/rules.gni » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698