Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Unified Diff: components/web_contents_delegate_android/web_contents_delegate_android.cc

Issue 22314005: [Android] On calling openNewTab, pass the disposition instead of incognito. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: added missing .template (forgot) Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/web_contents_delegate_android/web_contents_delegate_android.cc
diff --git a/components/web_contents_delegate_android/web_contents_delegate_android.cc b/components/web_contents_delegate_android/web_contents_delegate_android.cc
index f2003c928bdb644ec2932de1a4a8d397b546ed2b..3ca7e4923126db2fe1898b69fb80c5a584c122c0 100644
--- a/components/web_contents_delegate_android/web_contents_delegate_android.cc
+++ b/components/web_contents_delegate_android/web_contents_delegate_android.cc
@@ -91,19 +91,19 @@ WebContents* WebContentsDelegateAndroid::OpenURLFromTab(
ScopedJavaLocalRef<jbyteArray> post_data;
if (params.uses_post &&
params.browser_initiated_post_data.get() &&
- params.browser_initiated_post_data.get()->size()) {
+ params.browser_initiated_post_data->size()) {
post_data = base::android::ToJavaByteArray(
env,
reinterpret_cast<const uint8*>(
- params.browser_initiated_post_data.get()->front()),
- params.browser_initiated_post_data.get()->size());
joth 2013/08/06 04:04:21 could you put these .get() back? rsleevi was purpo
Kibeom Kim (inactive) 2013/08/06 04:36:01 Done.
+ params.browser_initiated_post_data->front()),
+ params.browser_initiated_post_data->size());
}
Java_WebContentsDelegateAndroid_openNewTab(env,
obj.obj(),
java_url.obj(),
extra_headers.obj(),
post_data.obj(),
- disposition == OFF_THE_RECORD);
+ disposition);
return NULL;
}

Powered by Google App Engine
This is Rietveld 408576698