components/web_contents_delegate_android/android/java/src/org/chromium/components/web_contents_delegate_android/WebContentsDelegateAndroid.java - Issue 22314005: [Android] On calling openNewTab, pass the disposition instead of incognito.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/web_contents_delegate_android/android/java/src/org/chromium/components/web_contents_delegate_android/WebContentsDelegateAndroid.java

Issue 22314005: [Android] On calling openNewTab, pass the disposition instead of incognito. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: added missing .template (forgot) Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « android_webview/java/src/org/chromium/android_webview/AwWebContentsDelegateAdapter.java ('k') | components/web_contents_delegate_android/web_contents_delegate_android.cc » ('j') | components/web_contents_delegate_android/web_contents_delegate_android.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/web_contents_delegate_android/android/java/src/org/chromium/components/web_contents_delegate_android/WebContentsDelegateAndroid.java

diff --git a/components/web_contents_delegate_android/android/java/src/org/chromium/components/web_contents_delegate_android/WebContentsDelegateAndroid.java b/components/web_contents_delegate_android/android/java/src/org/chromium/components/web_contents_delegate_android/WebContentsDelegateAndroid.java

index 62d24031dc41c8bee70839e77fc42eb0e0486153..11db80d1381d324c671b44e8a6aff91ed4532344 100644

--- a/components/web_contents_delegate_android/android/java/src/org/chromium/components/web_contents_delegate_android/WebContentsDelegateAndroid.java

+++ b/components/web_contents_delegate_android/android/java/src/org/chromium/components/web_contents_delegate_android/WebContentsDelegateAndroid.java

@@ -26,7 +26,7 @@ public class WebContentsDelegateAndroid {

// Equivalent of WebCore::WebConsoleMessage::LevelError.

public static final int LOG_LEVEL_ERROR = 3;

- // Flags passed to the WebContentsDelegate.navigationStateChanged to tell it

+ // Flags passed to the WebContentsDelegateAndroid.navigationStateChanged to tell it

// what has changed. Should match the values in invalidate_type.h.

// Equivalent of InvalidateTypes::INVALIDATE_TYPE_URL.

public static final int INVALIDATE_TYPE_URL = 1 << 0;

@@ -48,7 +48,7 @@ public class WebContentsDelegateAndroid {

}

@CalledByNative

- public void openNewTab(String url, String extraHeaders, byte[] postData, boolean incognito) {

+ public void openNewTab(String url, String extraHeaders, byte[] postData, int disposition) {

joth 2013/08/06 04:04:21 could you add a comment saying which class to use

Kibeom Kim (inactive) 2013/08/06 04:36:01 Done.

}

@CalledByNative