[Android] On calling openNewTab, pass the disposition instead of incognito.

components/web_contents_delegate_android/web_contents_delegate_android.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/web_contents_delegate_android/web_contents_delegate_android.h"
 
 #include <android/keycodes.h>
 
 #include "base/android/jni_android.h"
 #include "base/android/jni_array.h"
@@ skipping 73 matching lines @@
       disposition == NEW_BACKGROUND_TAB ||
       disposition == OFF_THE_RECORD) {
     JNIEnv* env = AttachCurrentThread();
     ScopedJavaLocalRef<jstring> java_url =
         ConvertUTF8ToJavaString(env, url.spec());
     ScopedJavaLocalRef<jstring> extra_headers =
             ConvertUTF8ToJavaString(env, params.extra_headers);
     ScopedJavaLocalRef<jbyteArray> post_data;
     if (params.uses_post &&
         params.browser_initiated_post_data.get() &&
-        params.browser_initiated_post_data.get()->size()) {
+        params.browser_initiated_post_data->size()) {
       post_data = base::android::ToJavaByteArray(
           env,
           reinterpret_cast<const uint8*>(
-              params.browser_initiated_post_data.get()->front()),
-          params.browser_initiated_post_data.get()->size());

[joth, 2013/08/06 04:04:21]

could you put these .get() back? rsleevi was purposely adding them not long ago
as part of a transition in implicit bool operator.
(unless that transition is done now? I didn't see any PSA)

[Kibeom Kim (inactive), 2013/08/06 04:36:01]

Done.

+              params.browser_initiated_post_data->front()),
+          params.browser_initiated_post_data->size());
     }
     Java_WebContentsDelegateAndroid_openNewTab(env,
                                                obj.obj(),
                                                java_url.obj(),
                                                extra_headers.obj(),
                                                post_data.obj(),
-                                               disposition == OFF_THE_RECORD);
+                                               disposition);
     return NULL;
   }
 
   source->GetController().LoadURL(url, params.referrer, transition,
                                   std::string());
   return source;
 }
 
 void WebContentsDelegateAndroid::NavigationStateChanged(
     const WebContents* source, unsigned changed_flags) {
@@ skipping 235 matching lines @@
 
 bool RegisterWebContentsDelegateAndroid(JNIEnv* env) {
   if (!HasClass(env, kWebContentsDelegateAndroidClassPath)) {
     DLOG(ERROR) << "Unable to find class WebContentsDelegateAndroid!";
     return false;
   }
   return RegisterNativesImpl(env);
 }
 
 }  // namespace web_contents_delegate_android