Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1662)

Unified Diff: extensions/browser/guest_view/web_view/web_ui/web_ui_url_fetcher.cc

Issue 2231353002: Make FileReader return ownership of the string content (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: address comments Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/guest_view/web_view/web_ui/web_ui_url_fetcher.cc
diff --git a/extensions/browser/guest_view/web_view/web_ui/web_ui_url_fetcher.cc b/extensions/browser/guest_view/web_view/web_ui/web_ui_url_fetcher.cc
index 6293c21188d9d3d58ad6d4be30f2670ac6b086e8..3366ee67ec7db9507bd6af8a06da63eb466e30d6 100644
--- a/extensions/browser/guest_view/web_view/web_ui/web_ui_url_fetcher.cc
+++ b/extensions/browser/guest_view/web_view/web_ui/web_ui_url_fetcher.cc
@@ -39,10 +39,10 @@ void WebUIURLFetcher::Start() {
void WebUIURLFetcher::OnURLFetchComplete(const net::URLFetcher* source) {
CHECK_EQ(fetcher_.get(), source);
- std::string data;
+ std::unique_ptr<std::string> data(new std::string());
bool result = false;
if (fetcher_->GetStatus().status() == net::URLRequestStatus::SUCCESS) {
- result = fetcher_->GetResponseAsString(&data);
+ result = fetcher_->GetResponseAsString(data.get());
DCHECK(result);
}
fetcher_.reset();
@@ -50,5 +50,5 @@ void WebUIURLFetcher::OnURLFetchComplete(const net::URLFetcher* source) {
// are destroyed at the end of the method.
auto callback_cache = callback_;
callback_.Reset();
- callback_cache.Run(result, data);
+ callback_cache.Run(result, std::move(data));
}
« no previous file with comments | « extensions/browser/guest_view/web_view/web_ui/web_ui_url_fetcher.h ('k') | extensions/browser/web_ui_user_script_loader.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698