extensions/browser/guest_view/web_view/web_ui/web_ui_url_fetcher.h - Issue 2231353002: Make FileReader return ownership of the string content

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/guest_view/web_view/web_ui/web_ui_url_fetcher.h

Issue 2231353002: Make FileReader return ownership of the string content (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address comments Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « extensions/browser/file_reader_unittest.cc ('k') | extensions/browser/guest_view/web_view/web_ui/web_ui_url_fetcher.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/guest_view/web_view/web_ui/web_ui_url_fetcher.h

diff --git a/extensions/browser/guest_view/web_view/web_ui/web_ui_url_fetcher.h b/extensions/browser/guest_view/web_view/web_ui/web_ui_url_fetcher.h

index cdf2bdc91de1deece984892b2207a22b8d8a9375..517a1cb5b674d178e3a8e9603366fcafb5b1c234 100644

--- a/extensions/browser/guest_view/web_view/web_ui/web_ui_url_fetcher.h

+++ b/extensions/browser/guest_view/web_view/web_ui/web_ui_url_fetcher.h

@@ -29,7 +29,8 @@ class WebUIURLFetcher : public net::URLFetcherDelegate {

// Parameters:

// - whether the request is success.

// - If yes, the content of the file.

- using WebUILoadFileCallback = base::Callback<void(bool, const std::string&)>;

+ using WebUILoadFileCallback =

+ base::Callback<void(bool, std::unique_ptr<std::string>)>;

WebUIURLFetcher(content::BrowserContext* context,

int render_process_id,

« no previous file with comments | « extensions/browser/file_reader_unittest.cc ('k') | extensions/browser/guest_view/web_view/web_ui/web_ui_url_fetcher.cc » ('j') | no next file with comments »