extensions/browser/web_ui_user_script_loader.h - Issue 2231353002: Make FileReader return ownership of the string content

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/web_ui_user_script_loader.h

Issue 2231353002: Make FileReader return ownership of the string content (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address comments Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « extensions/browser/guest_view/web_view/web_ui/web_ui_url_fetcher.cc ('k') | extensions/browser/web_ui_user_script_loader.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/web_ui_user_script_loader.h

diff --git a/extensions/browser/web_ui_user_script_loader.h b/extensions/browser/web_ui_user_script_loader.h

index ea77161d7d821a1d913381d8d34a5a9648d26a81..bda40d7e426104a8f361cfaa69d97e6bbf144ae8 100644

--- a/extensions/browser/web_ui_user_script_loader.h

+++ b/extensions/browser/web_ui_user_script_loader.h

@@ -43,7 +43,7 @@ class WebUIUserScriptLoader : public extensions::UserScriptLoader {

// Called at the end of each fetch, tracking whether all fetches are done.

void OnSingleWebUIURLFetchComplete(extensions::UserScript::File* script_file,

bool success,

- const std::string& data);

+ std::unique_ptr<std::string> data);

// Called when the loads of the user scripts are done.

void OnWebUIURLFetchComplete();