Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 2231093003: cc: Remove FinishAllRendering, as it doesn't do anything anymore. (Closed)

Created:
4 years, 4 months ago by danakj
Modified:
4 years, 4 months ago
Reviewers:
jennyz, piman
CC:
chromium-reviews, Ian Vollick, sievers+watch_chromium.org, jbauman+watch_chromium.org, piman+watch_chromium.org, kalyank, cc-bugs_chromium.org, danakj+watch_chromium.org, enne (OOO)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Remove FinishAllRendering, as it doesn't do anything anymore. DelegatingRenderer's Finish() is an empty function. R=piman@chromium.org TBR=jennyz BUG=606056 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel Committed: https://crrev.com/ea91819a259ff1ca9ededf03fb8c3fc6c47b5dd5 Cr-Commit-Position: refs/heads/master@{#411474}

Patch Set 1 #

Patch Set 2 : finishallrendering: . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -89 lines) Patch
M ash/system/chromeos/power/power_event_observer.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M cc/output/delegating_renderer.h View 1 chunk +0 lines, -2 lines 0 comments Download
M cc/output/gl_renderer.h View 1 chunk +0 lines, -3 lines 0 comments Download
M cc/output/gl_renderer.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M cc/output/renderer.h View 1 chunk +0 lines, -3 lines 0 comments Download
M cc/output/software_renderer.h View 1 chunk +0 lines, -1 line 0 comments Download
M cc/output/software_renderer.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M cc/test/fake_proxy.h View 1 chunk +0 lines, -1 line 0 comments Download
M cc/trees/channel_main.h View 1 chunk +0 lines, -1 line 0 comments Download
M cc/trees/layer_tree_host.h View 1 chunk +0 lines, -2 lines 0 comments Download
M cc/trees/layer_tree_host.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M cc/trees/layer_tree_host_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M cc/trees/layer_tree_host_impl.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M cc/trees/proxy.h View 1 chunk +0 lines, -2 lines 0 comments Download
M cc/trees/proxy_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M cc/trees/proxy_impl.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M cc/trees/proxy_main.h View 1 chunk +0 lines, -1 line 0 comments Download
M cc/trees/proxy_main.cc View 1 chunk +0 lines, -11 lines 0 comments Download
M cc/trees/remote_channel_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M cc/trees/remote_channel_impl.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M cc/trees/remote_channel_main.h View 1 chunk +0 lines, -1 line 0 comments Download
M cc/trees/remote_channel_main.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M cc/trees/single_thread_proxy.h View 1 chunk +0 lines, -1 line 0 comments Download
M cc/trees/single_thread_proxy.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M cc/trees/threaded_channel.h View 1 chunk +0 lines, -1 line 0 comments Download
M cc/trees/threaded_channel.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M ui/compositor/compositor.h View 1 chunk +0 lines, -3 lines 0 comments Download
M ui/compositor/compositor.cc View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 24 (14 generated)
danakj
4 years, 4 months ago (2016-08-10 21:48:44 UTC) #4
danakj
+jennyz@chromium.org for ash/ Removing a very long and windy call to an empty function.
4 years, 4 months ago (2016-08-10 21:49:28 UTC) #6
danakj
On 2016/08/10 21:49:28, danakj wrote: > mailto:+jennyz@chromium.org for ash/ > > Removing a very long ...
4 years, 4 months ago (2016-08-10 21:49:50 UTC) #9
piman
lgtm
4 years, 4 months ago (2016-08-10 22:19:53 UTC) #10
danakj
TBR'in jennyz
4 years, 4 months ago (2016-08-11 16:56:31 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2231093003/20001
4 years, 4 months ago (2016-08-11 16:57:14 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/276270)
4 years, 4 months ago (2016-08-11 19:52:45 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2231093003/20001
4 years, 4 months ago (2016-08-11 22:05:33 UTC) #20
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-12 00:26:09 UTC) #22
commit-bot: I haz the power
4 years, 4 months ago (2016-08-12 00:28:39 UTC) #24
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ea91819a259ff1ca9ededf03fb8c3fc6c47b5dd5
Cr-Commit-Position: refs/heads/master@{#411474}

Powered by Google App Engine
This is Rietveld 408576698