Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Side by Side Diff: cc/trees/remote_channel_impl.cc

Issue 2231093003: cc: Remove FinishAllRendering, as it doesn't do anything anymore. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: finishallrendering: . Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « cc/trees/remote_channel_impl.h ('k') | cc/trees/remote_channel_main.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "cc/trees/remote_channel_impl.h" 5 #include "cc/trees/remote_channel_impl.h"
6 6
7 #include "base/bind_helpers.h" 7 #include "base/bind_helpers.h"
8 #include "base/memory/ptr_util.h" 8 #include "base/memory/ptr_util.h"
9 #include "base/single_thread_task_runner.h" 9 #include "base/single_thread_task_runner.h"
10 #include "cc/animation/animation_events.h" 10 #include "cc/animation/animation_events.h"
(...skipping 132 matching lines...) Expand 10 before | Expand all | Expand 10 after
143 VLOG(1) << "Received redraw request from the engine."; 143 VLOG(1) << "Received redraw request from the engine.";
144 const proto::SetNeedsRedraw& set_needs_redraw_message = 144 const proto::SetNeedsRedraw& set_needs_redraw_message =
145 proto.set_needs_redraw_message(); 145 proto.set_needs_redraw_message();
146 gfx::Rect damaged_rect = 146 gfx::Rect damaged_rect =
147 ProtoToRect(set_needs_redraw_message.damaged_rect()); 147 ProtoToRect(set_needs_redraw_message.damaged_rect());
148 PostSetNeedsRedrawToImpl(damaged_rect); 148 PostSetNeedsRedrawToImpl(damaged_rect);
149 } break; 149 } break;
150 } 150 }
151 } 151 }
152 152
153 void RemoteChannelImpl::FinishAllRendering() {
154 NOTREACHED() << "Should not be called on the remote client LayerTreeHost";
155 }
156
157 bool RemoteChannelImpl::IsStarted() const { 153 bool RemoteChannelImpl::IsStarted() const {
158 DCHECK(task_runner_provider_->IsMainThread()); 154 DCHECK(task_runner_provider_->IsMainThread());
159 return main().started; 155 return main().started;
160 } 156 }
161 157
162 bool RemoteChannelImpl::CommitToActiveTree() const { 158 bool RemoteChannelImpl::CommitToActiveTree() const {
163 return false; 159 return false;
164 } 160 }
165 161
166 void RemoteChannelImpl::SetOutputSurface(OutputSurface* output_surface) { 162 void RemoteChannelImpl::SetOutputSurface(OutputSurface* output_surface) {
(...skipping 371 matching lines...) Expand 10 before | Expand all | Expand 10 after
538 534
539 RemoteChannelImpl::CompositorThreadOnly::CompositorThreadOnly( 535 RemoteChannelImpl::CompositorThreadOnly::CompositorThreadOnly(
540 base::WeakPtr<RemoteChannelImpl> remote_channel_weak_ptr) 536 base::WeakPtr<RemoteChannelImpl> remote_channel_weak_ptr)
541 : proxy_impl(nullptr), 537 : proxy_impl(nullptr),
542 proxy_impl_weak_factory(nullptr), 538 proxy_impl_weak_factory(nullptr),
543 remote_channel_weak_ptr(remote_channel_weak_ptr) {} 539 remote_channel_weak_ptr(remote_channel_weak_ptr) {}
544 540
545 RemoteChannelImpl::CompositorThreadOnly::~CompositorThreadOnly() {} 541 RemoteChannelImpl::CompositorThreadOnly::~CompositorThreadOnly() {}
546 542
547 } // namespace cc 543 } // namespace cc
OLDNEW
« no previous file with comments | « cc/trees/remote_channel_impl.h ('k') | cc/trees/remote_channel_main.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698