[DevTools] Recognize node remote target type

[DevTools] Recognize node remote target type

I redid the patch to rely on target type attribute (Node.js specifies "node")

BUG=636539
R=dgozman@chromium.org, pfeldman@chromium.org

Committed: https://crrev.com/ed16d6adf26bb798da57e59be34861d5083ba790
Cr-Commit-Position: refs/heads/master@{#411341}

[eostroukhov, 2016-08-10 21:58:05]

Please take a look.

[eostroukhov, 2016-08-10 21:58:35]

The CQ bit was checked by eostroukhov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-10 21:59:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[eostroukhov, 2016-08-10 22:51:47]

Redid to use target attribute

[eostroukhov, 2016-08-10 22:53:14]

Description was changed from

==========
[DevTools] Retain devtools query string

Query string is now passed on, except for the ws parameter.

BUG=636539
R=dgozman@chromium.org, pfeldman@chromium.org
==========

to

==========
[DevTools] Recognize node remote target type

I redid the patch to rely on target type attribute (Node.js specifies "node")

BUG=636539
R=dgozman@chromium.org, pfeldman@chromium.org
==========

[eostroukhov, 2016-08-10 22:53:36]

I updated the CL, as per offline discussion. PTAL.

[dgozman, 2016-08-10 23:13:43]

https://codereview.chromium.org/2230993004/diff/20001/chrome/browser/devtools...
File chrome/browser/devtools/device/devtools_android_bridge.cc (right):

https://codereview.chromium.org/2230993004/diff/20001/chrome/browser/devtools...
chrome/browser/devtools/device/devtools_android_bridge.cc:530: bool isWorker =
remote_type_ == kTargetTypeWorker ||
Please change these to is_worker and is_v8_only.

https://codereview.chromium.org/2230993004/diff/20001/chrome/browser/devtools...
File chrome/browser/devtools/devtools_window.h (right):

https://codereview.chromium.org/2230993004/diff/20001/chrome/browser/devtools...
chrome/browser/devtools/devtools_window.h:106: bool isWorker,
Please change these to is_worker and is_v8_only.

https://codereview.chromium.org/2230993004/diff/20001/chrome/browser/devtools...
chrome/browser/devtools/devtools_window.h:251: bool v8_frontend,
v8_only_frontend

https://codereview.chromium.org/2230993004/diff/20001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/devtools_ui.cc (right):

https://codereview.chromium.org/2230993004/diff/20001/chrome/browser/ui/webui...
chrome/browser/ui/webui/devtools_ui.cc:19: #include "net/base/url_util.h"
Revert this one.

[eostroukhov, 2016-08-10 23:30:23]

Comments were addressed

[eostroukhov, 2016-08-10 23:30:48]

The CQ bit was checked by eostroukhov@chromium.org to run a CQ dry run

[eostroukhov, 2016-08-10 23:31:08]

I addressed the comments, please take another look.

https://codereview.chromium.org/2230993004/diff/20001/chrome/browser/devtools...
File chrome/browser/devtools/device/devtools_android_bridge.cc (right):

https://codereview.chromium.org/2230993004/diff/20001/chrome/browser/devtools...
chrome/browser/devtools/device/devtools_android_bridge.cc:530: bool isWorker =
remote_type_ == kTargetTypeWorker ||
On 2016/08/10 23:13:43, dgozman wrote:
> Please change these to is_worker and is_v8_only.

Done.

https://codereview.chromium.org/2230993004/diff/20001/chrome/browser/devtools...
File chrome/browser/devtools/devtools_window.h (right):

https://codereview.chromium.org/2230993004/diff/20001/chrome/browser/devtools...
chrome/browser/devtools/devtools_window.h:106: bool isWorker,
On 2016/08/10 23:13:43, dgozman wrote:
> Please change these to is_worker and is_v8_only.

Done.

https://codereview.chromium.org/2230993004/diff/20001/chrome/browser/devtools...
chrome/browser/devtools/devtools_window.h:251: bool v8_frontend,
On 2016/08/10 23:13:43, dgozman wrote:
> v8_only_frontend

Done.

https://codereview.chromium.org/2230993004/diff/20001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/devtools_ui.cc (right):

https://codereview.chromium.org/2230993004/diff/20001/chrome/browser/ui/webui...
chrome/browser/ui/webui/devtools_ui.cc:19: #include "net/base/url_util.h"
On 2016/08/10 23:13:43, dgozman wrote:
> Revert this one.

Done.

[commit-bot: I haz the power, 2016-08-10 23:32:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dgozman, 2016-08-11 00:13:07]

lgtm

[commit-bot: I haz the power, 2016-08-11 01:36:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-11 01:36:41]

Dry run: This issue passed the CQ dry run.

[eostroukhov, 2016-08-11 15:56:31]

The CQ bit was checked by eostroukhov@chromium.org

[commit-bot: I haz the power, 2016-08-11 15:57:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-11 16:01:16]

Description was changed from

==========
[DevTools] Recognize node remote target type

I redid the patch to rely on target type attribute (Node.js specifies "node")

BUG=636539
R=dgozman@chromium.org, pfeldman@chromium.org
==========

to

==========
[DevTools] Recognize node remote target type

I redid the patch to rely on target type attribute (Node.js specifies "node")

BUG=636539
R=dgozman@chromium.org, pfeldman@chromium.org
==========

[commit-bot: I haz the power, 2016-08-11 16:01:17]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-08-11 16:04:28]

Description was changed from

==========
[DevTools] Recognize node remote target type

I redid the patch to rely on target type attribute (Node.js specifies "node")

BUG=636539
R=dgozman@chromium.org, pfeldman@chromium.org
==========

to

==========
[DevTools] Recognize node remote target type

I redid the patch to rely on target type attribute (Node.js specifies "node")

BUG=636539
R=dgozman@chromium.org, pfeldman@chromium.org

Committed: https://crrev.com/ed16d6adf26bb798da57e59be34861d5083ba790
Cr-Commit-Position: refs/heads/master@{#411341}
==========

[commit-bot: I haz the power, 2016-08-11 16:04:29]

Patchset 3 (id:??) landed as
https://crrev.com/ed16d6adf26bb798da57e59be34861d5083ba790
Cr-Commit-Position: refs/heads/master@{#411341}