Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(940)

Unified Diff: chrome/browser/devtools/device/devtools_android_bridge.cc

Issue 2230993004: [DevTools] Recognize node remote target type (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Comments were addressed Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/devtools/devtools_target_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/devtools/device/devtools_android_bridge.cc
diff --git a/chrome/browser/devtools/device/devtools_android_bridge.cc b/chrome/browser/devtools/device/devtools_android_bridge.cc
index 8593912a31dec51e414023e46efc1738e942c7b0..43eb41908fcebf091a852a7ef52bad598ba915ec 100644
--- a/chrome/browser/devtools/device/devtools_android_bridge.cc
+++ b/chrome/browser/devtools/device/devtools_android_bridge.cc
@@ -527,10 +527,11 @@ static void NoOp(int, const std::string&) {}
void DevToolsAndroidBridge::RemotePageTarget::Inspect(Profile* profile) const {
Activate();
- bool isWorker = remote_type_ == kTargetTypeWorker ||
- remote_type_ == kTargetTypeServiceWorker;
+ bool is_worker = remote_type_ == kTargetTypeWorker ||
+ remote_type_ == kTargetTypeServiceWorker;
+ bool is_v8_only = remote_type_ == kTargetTypeNode;
DevToolsWindow::OpenExternalFrontend(profile, frontend_url_, GetAgentHost(),
- isWorker);
+ is_worker, is_v8_only);
}
bool DevToolsAndroidBridge::RemotePageTarget::Activate() const {
« no previous file with comments | « no previous file | chrome/browser/devtools/devtools_target_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698