Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(333)

Unified Diff: chrome/browser/devtools/devtools_window.cc

Issue 2230993004: [DevTools] Recognize node remote target type (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Comments were addressed Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/devtools/devtools_window.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/devtools/devtools_window.cc
diff --git a/chrome/browser/devtools/devtools_window.cc b/chrome/browser/devtools/devtools_window.cc
index 5a3f23b885d975594ebb5a3560772d05082ce5c8..5708765ac40e2ebb6292dacdd57be210dbee1353 100644
--- a/chrome/browser/devtools/devtools_window.cc
+++ b/chrome/browser/devtools/devtools_window.cc
@@ -450,7 +450,7 @@ void DevToolsWindow::OpenDevToolsWindowForWorker(
DevToolsWindow* DevToolsWindow::CreateDevToolsWindowForWorker(
Profile* profile) {
content::RecordAction(base::UserMetricsAction("DevTools_InspectWorker"));
- return Create(profile, GURL(), NULL, true, std::string(), false, "");
+ return Create(profile, GURL(), NULL, true, false, std::string(), false, "");
}
// static
@@ -473,8 +473,8 @@ void DevToolsWindow::OpenDevToolsWindow(
const scoped_refptr<content::DevToolsAgentHost>& agent_host) {
DevToolsWindow* window = FindDevToolsWindow(agent_host.get());
if (!window) {
- window = DevToolsWindow::Create(
- profile, GURL(), nullptr, false, std::string(), false, std::string());
+ window = DevToolsWindow::Create(profile, GURL(), nullptr, false, false,
+ std::string(), false, std::string());
if (!window)
return;
window->bindings_->AttachTo(agent_host);
@@ -503,10 +503,11 @@ void DevToolsWindow::OpenExternalFrontend(
Profile* profile,
const std::string& frontend_url,
const scoped_refptr<content::DevToolsAgentHost>& agent_host,
- bool isWorker) {
+ bool is_worker,
+ bool is_v8_only) {
DevToolsWindow* window = FindDevToolsWindow(agent_host.get());
if (!window) {
- window = Create(profile, GURL(), nullptr, isWorker,
+ window = Create(profile, GURL(), nullptr, is_worker, is_v8_only,
DevToolsUI::GetProxyURL(frontend_url).spec(), false, std::string());
if (!window)
return;
@@ -532,7 +533,7 @@ void DevToolsWindow::ToggleDevToolsWindow(
content::RecordAction(
base::UserMetricsAction("DevTools_InspectRenderer"));
window = Create(profile, GURL(), inspected_web_contents,
- false, std::string(), true, settings);
+ false, false, std::string(), true, settings);
if (!window)
return;
window->bindings_->AttachTo(agent.get());
@@ -782,6 +783,7 @@ DevToolsWindow* DevToolsWindow::Create(
const GURL& frontend_url,
content::WebContents* inspected_web_contents,
bool shared_worker_frontend,
+ bool v8_only_frontend,
const std::string& remote_frontend,
bool can_dock,
const std::string& settings) {
@@ -803,6 +805,7 @@ DevToolsWindow* DevToolsWindow::Create(
// Create WebContents with devtools.
GURL url(GetDevToolsURL(profile, frontend_url,
shared_worker_frontend,
+ v8_only_frontend,
remote_frontend,
can_dock));
std::unique_ptr<WebContents> main_web_contents(
@@ -824,6 +827,7 @@ DevToolsWindow* DevToolsWindow::Create(
GURL DevToolsWindow::GetDevToolsURL(Profile* profile,
const GURL& base_url,
bool shared_worker_frontend,
+ bool v8_only_frontend,
const std::string& remote_frontend,
bool can_dock) {
// Compatibility errors are encoded with data urls, pass them
@@ -840,6 +844,8 @@ GURL DevToolsWindow::GetDevToolsURL(Profile* profile,
((frontend_url.find("?") == std::string::npos) ? "?" : "&"));
if (shared_worker_frontend)
url_string += "&isSharedWorker=true";
+ if (v8_only_frontend)
+ url_string += "&v8only=true";
if (remote_frontend.size()) {
url_string += "&remoteFrontend=true";
} else {
« no previous file with comments | « chrome/browser/devtools/devtools_window.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698