Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6698)

Unified Diff: chrome/renderer/pepper/pnacl_translation_resource_host.h

Issue 22309007: Add success status to ReportTranslationFinished in ppb_nacl_private and IPC (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix unit test Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/pepper/pnacl_translation_resource_host.h
diff --git a/chrome/renderer/pepper/pnacl_translation_resource_host.h b/chrome/renderer/pepper/pnacl_translation_resource_host.h
index 9f1a2040fc2ad00019d2a1887611694ec00fa92c..d542c373132e1a20927625ae076c3784d7c03d51 100644
--- a/chrome/renderer/pepper/pnacl_translation_resource_host.h
+++ b/chrome/renderer/pepper/pnacl_translation_resource_host.h
@@ -33,7 +33,7 @@ class PnaclTranslationResourceHost : public IPC::ChannelProxy::MessageFilter {
PP_Bool* is_hit,
PP_FileHandle* file_handle,
scoped_refptr<ppapi::TrackedCallback> callback);
- void ReportTranslationFinished(PP_Instance instance);
+ void ReportTranslationFinished(PP_Instance instance, PP_Bool error);
jvoung (off chromium) 2013/08/06 18:35:28 replace "error" with "success" ?
Derek Schuff 2013/08/06 21:21:13 Ah yeah... it was originally "error" but I replace
// Ensure that PNaCl resources (pnacl-llc.nexe, linker, libs) are installed.
void EnsurePnaclInstalled(PP_Instance instance,
@@ -74,7 +74,8 @@ class PnaclTranslationResourceHost : public IPC::ChannelProxy::MessageFilter {
PP_Bool* is_hit,
PP_FileHandle* file_handle,
scoped_refptr<ppapi::TrackedCallback> callback);
- void SendReportTranslationFinished(PP_Instance instance);
+ void SendReportTranslationFinished(PP_Instance instance,
+ PP_Bool success);
void SendEnsurePnaclInstalled(PP_Instance instance,
scoped_refptr<ppapi::TrackedCallback> callback);

Powered by Google App Engine
This is Rietveld 408576698