Add success status to ReportTranslationFinished in ppb_nacl_private and IPC

chrome/renderer/pepper/pnacl_translation_resource_host.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_RENDERER_PEPPER_PNACL_TRANSLATION_RESOURCE_HOST_H_
 #define CHROME_RENDERER_PEPPER_PNACL_TRANSLATION_RESOURCE_HOST_H_
 
 #include <map>
 #include <vector>
 
@@ skipping 15 matching lines @@
 class PnaclTranslationResourceHost : public IPC::ChannelProxy::MessageFilter {
  public:
   explicit PnaclTranslationResourceHost(
       const scoped_refptr<base::MessageLoopProxy>& io_message_loop);
   void RequestNexeFd(int render_view_id,
                      PP_Instance instance,
                      const nacl::PnaclCacheInfo& cache_info,
                      PP_Bool* is_hit,
                      PP_FileHandle* file_handle,
                      scoped_refptr<ppapi::TrackedCallback> callback);
-  void ReportTranslationFinished(PP_Instance instance);
+  void ReportTranslationFinished(PP_Instance instance, PP_Bool error);

[jvoung (off chromium), 2013/08/06 18:35:28]

replace "error" with "success" ?

[Derek Schuff, 2013/08/06 21:21:13]

Ah yeah... it was originally "error" but I replaced it with "success" to be
consistent with EnsurePnaclInstalledReply

 
   // Ensure that PNaCl resources (pnacl-llc.nexe, linker, libs) are installed.
   void EnsurePnaclInstalled(PP_Instance instance,
                             scoped_refptr<ppapi::TrackedCallback> callback);
 
  protected:
   virtual ~PnaclTranslationResourceHost();
 
  private:
   class CacheRequestInfo {
@@ skipping 20 matching lines @@
   virtual void OnFilterAdded(IPC::Channel* channel) OVERRIDE;
   virtual void OnFilterRemoved() OVERRIDE;
   virtual void OnChannelClosing() OVERRIDE;
 
   void SendRequestNexeFd(int render_view_id,
                          PP_Instance instance,
                          const nacl::PnaclCacheInfo& cache_info,
                          PP_Bool* is_hit,
                          PP_FileHandle* file_handle,
                          scoped_refptr<ppapi::TrackedCallback> callback);
-  void SendReportTranslationFinished(PP_Instance instance);
+  void SendReportTranslationFinished(PP_Instance instance,
+                                     PP_Bool success);
   void SendEnsurePnaclInstalled(PP_Instance instance,
                                 scoped_refptr<ppapi::TrackedCallback> callback);
 
   void OnNexeTempFileReply(PP_Instance instance,
                            bool is_hit,
                            IPC::PlatformFileForTransit file);
   void CleanupCacheRequests();
   void OnEnsurePnaclInstalledReply(PP_Instance instance, bool success);
   void CleanupEnsurePnaclRequests();
 
   scoped_refptr<base::MessageLoopProxy> io_message_loop_;
 
   // Should be accessed on the io thread.
   IPC::Channel* channel_;
   CacheRequestInfoMap pending_cache_requests_;
   EnsurePnaclInstalledList pending_ensure_pnacl_requests_;
   DISALLOW_COPY_AND_ASSIGN(PnaclTranslationResourceHost);
 };
 
 #endif  // CHROME_RENDERER_PEPPER_PNACL_TRANSLATION_RESOURCE_HOST_H_