chrome/browser/nacl_host/pnacl_host_unittest.cc - Issue 22309007: Add success status to ReportTranslationFinished in ppb_nacl_private and IPC

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/nacl_host/pnacl_host_unittest.cc

Issue 22309007: Add success status to ReportTranslationFinished in ppb_nacl_private and IPC (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix unit test Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/nacl_host/pnacl_host.cc ('K') | « chrome/browser/nacl_host/pnacl_host.cc ('k') | chrome/renderer/pepper/pnacl_translation_resource_host.h » ('j') | chrome/renderer/pepper/pnacl_translation_resource_host.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/nacl_host/pnacl_host_unittest.cc

diff --git a/chrome/browser/nacl_host/pnacl_host_unittest.cc b/chrome/browser/nacl_host/pnacl_host_unittest.cc

index 7796aa61ab12ede8a22451010dd7f2d4cce0c0c8..cb5e8ef9bdd0a343559bd68d2e525260d90054f1 100644

--- a/chrome/browser/nacl_host/pnacl_host_unittest.cc

+++ b/chrome/browser/nacl_host/pnacl_host_unittest.cc

@@ -73,7 +73,7 @@ TEST_F(PnaclHostTest, BasicMiss) {

base::RunLoop().RunUntilIdle();

EXPECT_PENDING_TRANSLATIONS(1);

ExpectCallbackCount(1);

- host_->TranslationFinished(0, 0);

+ host_->TranslationFinished(0, 0, true);

EXPECT_PENDING_TRANSLATIONS(0);

host_->RendererClosing(0);

}

@@ -89,7 +89,7 @@ TEST_F(PnaclHostTest, BadArguments) {

base::Bind(&PnaclHostTest::CallbackExpectMiss, base::Unretained(this)));

EXPECT_PENDING_TRANSLATIONS(1);

- host_->TranslationFinished(0, 1); // nonexistent translation

+ host_->TranslationFinished(0, 1, true); // nonexistent translation

EXPECT_PENDING_TRANSLATIONS(1);

host_->RendererClosing(1); // nonexistent renderer

EXPECT_PENDING_TRANSLATIONS(1);