chrome/browser/nacl_host/nacl_host_message_filter.cc - Issue 22309007: Add success status to ReportTranslationFinished in ppb_nacl_private and IPC

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/nacl_host/nacl_host_message_filter.cc

Issue 22309007: Add success status to ReportTranslationFinished in ppb_nacl_private and IPC (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix unit test Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/nacl_host/nacl_host_message_filter.h ('k') | chrome/browser/nacl_host/pnacl_host.h » ('j') | chrome/browser/nacl_host/pnacl_host.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/nacl_host/nacl_host_message_filter.cc

diff --git a/chrome/browser/nacl_host/nacl_host_message_filter.cc b/chrome/browser/nacl_host/nacl_host_message_filter.cc

index 5980d728a66b0a07de6940d232c22c3f04e70dc8..c7c79358b27498435f60354f65f69b9408c163b0 100644

--- a/chrome/browser/nacl_host/nacl_host_message_filter.cc

+++ b/chrome/browser/nacl_host/nacl_host_message_filter.cc

@@ -186,9 +186,9 @@ void NaClHostMessageFilter::OnGetNexeFd(

pp_instance));

}

-void NaClHostMessageFilter::OnTranslationFinished(int instance) {

+void NaClHostMessageFilter::OnTranslationFinished(int instance, bool success) {

PnaclHost::GetInstance()->TranslationFinished(

- render_process_id_, instance);

+ render_process_id_, instance, success);

}

void NaClHostMessageFilter::OnNaClErrorStatus(int render_view_id,

« no previous file with comments | « chrome/browser/nacl_host/nacl_host_message_filter.h ('k') | chrome/browser/nacl_host/pnacl_host.h » ('j') | chrome/browser/nacl_host/pnacl_host.cc » ('J')