chrome/browser/nacl_host/nacl_host_message_filter.h - Issue 22309007: Add success status to ReportTranslationFinished in ppb_nacl_private and IPC

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/nacl_host/nacl_host_message_filter.h

Issue 22309007: Add success status to ReportTranslationFinished in ppb_nacl_private and IPC (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix unit test Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/nacl_host/nacl_host_message_filter.h

diff --git a/chrome/browser/nacl_host/nacl_host_message_filter.h b/chrome/browser/nacl_host/nacl_host_message_filter.h

index dccdf083370d8760140348e0dd8a4e1528d62a1b..7d31a9039780f21773a0658860d8eebf176759b9 100644

--- a/chrome/browser/nacl_host/nacl_host_message_filter.h

+++ b/chrome/browser/nacl_host/nacl_host_message_filter.h

@@ -59,7 +59,7 @@ class NaClHostMessageFilter : public content::BrowserMessageFilter {

void OnGetNexeFd(int render_view_id,

int pp_instance,

const nacl::PnaclCacheInfo& cache_info);

- void OnTranslationFinished(int instance);

+ void OnTranslationFinished(int instance, bool success);

void OnNaClErrorStatus(int render_view_id, int error_id);

void OnOpenNaClExecutable(int render_view_id,

const GURL& file_url,

« no previous file with comments | « no previous file | chrome/browser/nacl_host/nacl_host_message_filter.cc » ('j') | chrome/browser/nacl_host/pnacl_host.cc » ('J')