Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1959)

Unified Diff: chrome/browser/nacl_host/pnacl_host.h

Issue 22309007: Add success status to ReportTranslationFinished in ppb_nacl_private and IPC (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix unit test Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/nacl_host/pnacl_host.h
diff --git a/chrome/browser/nacl_host/pnacl_host.h b/chrome/browser/nacl_host/pnacl_host.h
index e449ce2817dbf0aea15102152c1c8c091bbbf2fe..2093b44cc12d13fce04a1936ee96d7731a073e9a 100644
--- a/chrome/browser/nacl_host/pnacl_host.h
+++ b/chrome/browser/nacl_host/pnacl_host.h
@@ -63,9 +63,11 @@ class PnaclHost {
const NexeFdCallback& cb);
// Called after the translation of a pexe instance identified by
- // |render_process_id| and |pp_instance| finishes. Store the nexe translated
- // for the instance in the cache.
- void TranslationFinished(int render_process_id, int pp_instance);
+ // |render_process_id| and |pp_instance| finishes. If |success| is true,
+ // store the nexe translated for the instance in the cache.
+ void TranslationFinished(int render_process_id,
+ int pp_instance,
+ bool success);
// Called when the renderer identified by |render_process_id| is closing.
// Clean up any outstanding translations for that renderer.

Powered by Google App Engine
This is Rietveld 408576698