Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2229523004:
[LayoutNG] Add units structures (Closed)
|
Created:
4 years, 4 months ago by cbiesinger Modified:
4 years, 4 months ago CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Description[LayoutNG] Add units structures
R=eae@chromium.org,ikilpatrick@chromium.org,glebl@chromium.org
BUG=635619
Committed: https://crrev.com/ce5161d7aed0cf105dbb4c9bf6a9dbcda5cbd672
Cr-Commit-Position: refs/heads/master@{#410732}
Patch Set 1 #
Total comments: 4
Patch Set 2 : review comment, and remove gypi change for now #Messages
Total messages: 14 (7 generated)
The CQ bit was checked by cbiesinger@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
LGTM w/nit https://codereview.chromium.org/2229523004/diff/1/third_party/WebKit/Source/c... File third_party/WebKit/Source/core/layout/ng/NGUnits.h (right): https://codereview.chromium.org/2229523004/diff/1/third_party/WebKit/Source/c... third_party/WebKit/Source/core/layout/ng/NGUnits.h:31: Add NGPhysicalRect (in addition) and a NGPixelSnappedRect (instead of the pixel snapped size and location as one cannot snap the one without the other).
Description was changed from ========== [layoutng] Add units structures R=eae@chromium.org,ikilpatrick@chromium.org,glebl@chromium.org BUG=635619 ========== to ========== [LayoutNG] Add units structures R=eae@chromium.org,ikilpatrick@chromium.org,glebl@chromium.org BUG=635619 ==========
https://codereview.chromium.org/2229523004/diff/1/third_party/WebKit/Source/c... File third_party/WebKit/Source/core/layout/ng/NGUnits.h (right): https://codereview.chromium.org/2229523004/diff/1/third_party/WebKit/Source/c... third_party/WebKit/Source/core/layout/ng/NGUnits.h:29: LayoutUnit y; If we want to be as close to the css specs as possible; we'll probably want this to be top, left.
The CQ bit was checked by cbiesinger@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from eae@chromium.org Link to the patchset: https://codereview.chromium.org/2229523004/#ps20001 (title: "review comment, and remove gypi change for now")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
https://codereview.chromium.org/2229523004/diff/1/third_party/WebKit/Source/c... File third_party/WebKit/Source/core/layout/ng/NGUnits.h (right): https://codereview.chromium.org/2229523004/diff/1/third_party/WebKit/Source/c... third_party/WebKit/Source/core/layout/ng/NGUnits.h:29: LayoutUnit y; On 2016/08/09 16:21:56, ikilpatrick wrote: > If we want to be as close to the css specs as possible; we'll probably want this > to be top, left. Done. https://codereview.chromium.org/2229523004/diff/1/third_party/WebKit/Source/c... third_party/WebKit/Source/core/layout/ng/NGUnits.h:31: On 2016/08/09 16:19:39, eae wrote: > Add NGPhysicalRect (in addition) and a NGPixelSnappedRect (instead of the pixel > snapped size and location as one cannot snap the one without the other). Done.
Message was sent while issue was closed.
Description was changed from ========== [LayoutNG] Add units structures R=eae@chromium.org,ikilpatrick@chromium.org,glebl@chromium.org BUG=635619 ========== to ========== [LayoutNG] Add units structures R=eae@chromium.org,ikilpatrick@chromium.org,glebl@chromium.org BUG=635619 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== [LayoutNG] Add units structures R=eae@chromium.org,ikilpatrick@chromium.org,glebl@chromium.org BUG=635619 ========== to ========== [LayoutNG] Add units structures R=eae@chromium.org,ikilpatrick@chromium.org,glebl@chromium.org BUG=635619 Committed: https://crrev.com/ce5161d7aed0cf105dbb4c9bf6a9dbcda5cbd672 Cr-Commit-Position: refs/heads/master@{#410732} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/ce5161d7aed0cf105dbb4c9bf6a9dbcda5cbd672 Cr-Commit-Position: refs/heads/master@{#410732} |
